Created attachment 255890 [details] New port configuration Marking the port unmaintained in the interim, will speak with current maintainer of `devel/isa-l` if they could be owning the submitted one.
Hi @sunpoet, I don't believe we've "met"; my name is Ravi Pokala, and I've been a src committer for several years. I work for Vdura (formerly known as Panasas), and my colleague Ilia has created a port for the ISA-L crypto framework. Since you are the maintainer of the ISA-L framework, we thought you might be willing to assist us in getting this related framework into the ports tree. If this is something you can help us with, we would greatly appreciate it; in that case, please contact Ilia with any questions or comments. If not, then I'll see if one of the other ports maintainers can help us out. Thanks, Ravi (rpokala@ ; wearing my Vdura hat)
Quick review +PORTVERSION= 2.25.0 +DISTVERSIONPREFIX= v See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github on the correct variables and order MAINTAINER= ports@FreeBSD.org This is a showstopper, it needs to have a maintainer Does it pass Poudriere? If so, what releases and arch's? Does make test pass?
Created attachment 257140 [details] New port configuration (reviewed) Adding new port configuration upon addressing review comments from Daniel
Thanks for reviewing this, Daniel > +PORTVERSION= 2.25.0 > +DISTVERSIONPREFIX= v > See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > on the correct variables and order Good catch, thanks - addressed in the updated patch. Interestingly, `portlint` didn't raise that concern. > MAINTAINER= ports@FreeBSD.org > This is a showstopper, it needs to have a maintainer Arranged the email address, the patch has been updated. > Does it pass Poudriere? If so, what releases and arch's? It does, against ports' `main` and FreeBSD 14.2 - please see below. $ poudriere bulk -j 142amd64 -v -J4 -b latest -C devel/isa-l_crypto ... [00:28:42] [01] [00:18:31] Finished devel/isa-l_crypto | isa-l_crypto-2.25.0_1: Success ... > Does make test pass? It does as well: $ poudriere testport -j 142amd64 -v -J4 -b latest -i devel/isa-l_crypto ... package name: isa-l_crypto-2.25.0_1 building for: FreeBSD 142amd64-default 14.2-RELEASE FreeBSD 14.2-RELEASE amd64 maintained by: freebsd@vdura.com ... [00:05:37] Installing packages [00:05:37] Installing run-depends for devel/isa-l_crypto | isa-l_crypto-2.25.0_1 [00:05:37] Installing devel/isa-l_crypto | isa-l_crypto-2.25.0_1 [142amd64-default] Installing isa-l_crypto-2.25.0_1... [142amd64-default] Extracting isa-l_crypto-2.25.0_1: 100% [00:05:38] Installing local Pkg repository to /usr/local/etc/pkg/repos [00:05:38] Remounting /usr/ports read-write [00:05:38] Mounting logs from: /usr/local/poudriere/data/logs/bulk/142amd64-default/2025-01-31_13h18m26s [00:05:38] Entering interactive test mode. Type 'exit' when done. ... $ make test ===> Testing for isa-l_crypto-2.25.0_1 ... PASS: sha1_mb/sha1_mb_test PASS: sha1_mb/sha1_mb_rand_test PASS: sha1_mb/sha1_mb_rand_update_test PASS: sha1_mb/sha1_mb_flush_test PASS: sha1_mb/sha1_mb_param_test PASS: mh_sha1/mh_sha1_test PASS: mh_sha1/mh_sha1_param_test PASS: md5_mb/md5_mb_test PASS: md5_mb/md5_mb_rand_test PASS: md5_mb/md5_mb_rand_update_test PASS: md5_mb/md5_mb_param_test PASS: sha256_mb/sha256_mb_test PASS: sha256_mb/sha256_mb_rand_test PASS: sha256_mb/sha256_mb_rand_update_test PASS: sha256_mb/sha256_mb_flush_test PASS: sha256_mb/sha256_mb_param_test PASS: sha512_mb/sha512_mb_test PASS: sha512_mb/sha512_mb_rand_test PASS: sha512_mb/sha512_mb_rand_update_test PASS: sha512_mb/sha512_mb_param_test PASS: mh_sha1_murmur3_x64_128/mh_sha1_murmur3_x64_128_param_test PASS: mh_sha256/mh_sha256_test PASS: mh_sha256/mh_sha256_param_test PASS: rolling_hash/rolling_hash2_test PASS: rolling_hash/rolling_hash2_param_test PASS: sm3_mb/sm3_ref_test PASS: sm3_mb/sm3_mb_param_test PASS: misc/version_test PASS: aes/cbc_std_vectors_test PASS: aes/gcm_std_vectors_test PASS: aes/gcm_nt_std_vectors_test PASS: aes/xts_128_test PASS: aes/xts_256_test PASS: aes/xts_128_expanded_key_test PASS: aes/xts_256_expanded_key_test PASS: aes/aes_param_test PASS: fips/self_tests_test ============================================================================ Testsuite summary for libisal_crypto 2.25.0 ============================================================================ # TOTAL: 37 # PASS: 37 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 Please let me know if there is anything else to adjust, and I'll be happy to complete that - thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=22ce7fa17bc9e86cfba62f73619b22766157d64a commit 22ce7fa17bc9e86cfba62f73619b22766157d64a Author: Ilia Sotnikov <isotnikov@vdura.com> AuthorDate: 2025-02-03 15:13:47 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2025-02-03 15:50:44 +0000 devel/isa-l_crypto: Add isa-l_crypto 2.25.0 ISA-L_crypto is a collection of optimized low-level functions targeting storage applications that includes multi-buffer and rolling hashes, along with block ciphers. PR: 283361 devel/Makefile | 1 + devel/isa-l_crypto/Makefile (new) | 28 ++++++++++++++++++++++++++++ devel/isa-l_crypto/distinfo (new) | 3 +++ devel/isa-l_crypto/pkg-descr (new) | 3 +++ devel/isa-l_crypto/pkg-plist (new) | 24 ++++++++++++++++++++++++ 5 files changed, 59 insertions(+)
Committed. Thanks!