Bug 283370 - net/tigervnc-server: Missing RUN_DEPENDS on x11/libxcvt
Summary: net/tigervnc-server: Missing RUN_DEPENDS on x11/libxcvt
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-16 22:13 UTC by Craig Leres
Modified: 2024-12-17 20:41 UTC (History)
2 users (show)

See Also:


Attachments
patch (1.03 KB, patch)
2024-12-16 22:14 UTC, Craig Leres
leres: maintainer-approval? (meta)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2024-12-16 22:13:30 UTC
I have a system with tigervnc-server installed but without xorg-server. I noticed there were no dependencies on libxcvt so I removed it and then noticed:

    % ldd /usr/local/bin/Xvnc | fgrep not
    libxcvt.so.0 => not found (0)
    % pkg which /usr/local/bin/Xvnc
    /usr/local/bin/Xvnc was installed by package tigervnc-server-1.14.1
    % pkg info -d tigervnc-server
    tigervnc-server-1.14.1:
            xkeyboard-config-2.41_4
            xkbcomp-1.4.7
            pixman-0.42.2
            libxshmfence-1.3.2
            libxkbfile-1.1.3
            libXtst-1.2.4
            libXrender-0.9.11
            libXrandr-1.5.4
            libXfixes-6.0.1
            libXext-1.3.6,1
            libXdmcp-1.1.5
            libXdamage-1.1.6
            libXau-1.0.11
            libX11-1.8.9,1
            libSM-1.2.4,1
            libICE-1.1.1,1
            libXfont2-2.0.6
            openssl33-3.3.2_1
            nettle-3.10_1
            ffmpeg-6.1.2_6,1
            gmp-6.3.0
            perl5-5.38.2_2
            mesa-libs-24.1.7_1
            libglvnd-1.7.0
            jpeg-turbo-3.0.4
            libunwind-20240221_1

Here's a patch to fix this. (I used RUN_DEPENDS, perhaps LIB_DEPENDS is more appropriate?)
Comment 1 Craig Leres freebsd_committer freebsd_triage 2024-12-16 22:14:03 UTC
Created attachment 255904 [details]
patch
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-17 00:49:52 UTC
Hi, as far as I see, I don't think it actually depends on libxcvt.


% pkg info -f tigervnc-server
tigervnc-server-1.14.0
Name           : tigervnc-server
Version        : 1.14.0
Installed on   : Tue Dec 17 09:19:33 2024 JST
Origin         : net/tigervnc-server
Architecture   : FreeBSD:14:amd64
Prefix         : /usr/local
Categories     : x11-servers net
Licenses       : GPLv2+
Maintainer     : meta@FreeBSD.org
WWW            : https://tigervnc.org/
Comment        : TigerVNC Server
Options        :
        DOCS           : on
        GNUTLS         : on
        PAM            : on
Shared Libs required:
        libxshmfence.so.1
        libunwind.so.8
        libswscale.so.7
        libpixman-1.so.0
        libnettle.so.8
        libjpeg.so.8
        libhogweed.so.6
        libgnutls.so.30
        libgmp.so.10
        libgbm.so.1
        libavutil.so.58
        libavcodec.so.60
        libXtst.so.6
        libXrandr.so.2
        libXfont2.so.2
        libXfixes.so.3
        libXext.so.6
        libXdmcp.so.6
        libXdamage.so.1
        libXau.so.6
        libX11.so.6
        libSM.so.6
        libICE.so.6
        libGL.so.1
Shared Libs provided:
        libvnc.so
Annotations    :
        FreeBSD_version: 1401000
        build_timestamp: 2024-11-28T03:17:18+0000
        built_by       : poudriere-git-3.4.2
        cpe            : cpe:2.3:a:tigervnc:tigervnc:1.14.0:::::freebsd14:x64
        port_checkout_unclean: no
        port_git_hash  : 19fbadfb9
        ports_top_checkout_unclean: no
        ports_top_git_hash: 07b331c5e
        repo_type      : binary
        repository     : FreeBSD
Flat size      : 3.85MiB
Description    :
This port provides server components of TigerVNC.

TigerVNC is a high-performance, platform-neutral implementation of VNC,
a client/server application that allows users to launch and interact with
graphical applications on remote machines.

% ldd /usr/local/bin/Xvnc|grep xcvt
%
Comment 3 Craig Leres freebsd_committer freebsd_triage 2024-12-17 01:41:27 UTC
(In reply to Koichiro Iwao from comment #2)
I don't doubt that pkg doesn't think it depends on libxcvt.

But Xvnc definitely depends on libxcvt on my system:

% ldd /usr/local/bin/Xvnc|grep xcvt
        libxcvt.so.0 => /usr/local/lib/libxcvt.so.0 (0x2dca8283c000)

Maybe this is impacted by port options?
Comment 4 Craig Leres freebsd_committer freebsd_triage 2024-12-17 01:51:47 UTC
(In reply to Craig Leres from comment #3)
I downloaded tigervnc-server-1.14.1.pkg from https://pkg.freebsd.org/FreeBSD:14:amd64/latest/All/ and the Xvnc it contains links against libxcvt.so.0

% ldd ./Xvnc | fgrep xcvt
        libxcvt.so.0 => /usr/local/lib/libxcvt.so.0 (0x370084da1000)
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-17 03:58:16 UTC
(In reply to Craig Leres from comment #3)
Thanks, got it. 1.14.0 on the current quarterly doesn't depend on libxcvt 1.14.1 seems to do. I'll update the dependency.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-17 04:35:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af0e83799c469de53b742d316bf485867d37ca7e

commit af0e83799c469de53b742d316bf485867d37ca7e
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2024-12-17 04:29:16 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2024-12-17 04:32:48 +0000

    net/tigervnc-server: explicitly declare dependency on libxcvt

    TigerVNC has dependency on libxcvt since 1.14.1.

    PR:             283370
    Reported by:    leres@

 net/tigervnc-server/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-17 04:36:49 UTC
Committed, feel free to close this if you confirmed the fix.
Comment 8 Craig Leres freebsd_committer freebsd_triage 2024-12-17 20:41:44 UTC
I've built/installed tigervnc-server and it looks good.

The only thing I might change is to remove libxcvt from BUILD_DEPENDS, it's likely redundant now.