Bug 283371 - ftp/filezilla fails to build
Summary: ftp/filezilla fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-16 22:50 UTC by andy
Modified: 2024-12-31 18:54 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andy 2024-12-16 22:50:14 UTC
FreeBSD FBSD15 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-n274302-675708aa402a: Mon Dec 16 13:57:15 EST 2024     root@FBSD15:/usr/obj/usr/src/amd64.amd64/sys/MYKERNEL amd64 1500029


Filezilla fails to compile with:

libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-json.lo -MD -MP -MF .deps/libfilezilla_la-json.Tpo -c json.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-json.o
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-jws.lo -MD -MP -MF .deps/libfilezilla_la-jws.Tpo -c jws.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-jws.o
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-buffer.lo -MD -MP -MF .deps/libfilezilla_la-buffer.Tpo -c buffer.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-buffer.o
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-local_filesys.lo -MD -MP -MF .deps/libfilezilla_la-local_filesys.Tpo -c local_filesys.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-local_filesys.o
In file included from encryption.cpp:1:
In file included from ./libfilezilla/encryption.hpp:13:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
In file included from jws.cpp:1:
In file included from ./libfilezilla/encode.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/hash.hpp:111:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
./libfilezilla/hash.hpp:111  :44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
111  111 |           std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
 |  ./libfilezilla/hash.hpp:113:22: note: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
   113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t length, unsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
   115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | strIn file included from        std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
hash.cpp:1:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
./libfilezilla/hash.hpp:  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/hash.hpp:111:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
113:22  111 |           std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/hash.hpp:113:22: note: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
:   uct char_traits;
      |        ^
113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t lnote: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
engt  113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t length, unsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
h./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
,   115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
u   45 | struct char_traits;
      |        ^
nsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
  115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
In file included from buffer.cpp:1:
In file included from ./libfilezilla/buffer.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
In file included from file.cpp:1:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
1 error generated.
gmake[1]: *** [Makefile:929: libfilezilla_la-buffer.lo] Error 1
gmake[1]: *** Waiting for unfinished jobs....
1 error generated.
gmake[1]: *** [Makefile:971: libfilezilla_la-file.lo] Error 1
1 error generated.
gmake[1]: *** [Makefile:978: libfilezilla_la-hash.lo] Error 1
1 error generated.
gmake[1]: *** [Makefile:943: libfilezilla_la-encryption.lo] Error 1
In file included from event_loop.cpp:1:
In file included from ./libfilezilla/event_loop.hpp:5:
In file included from ./libfilezilla/event.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:8:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-event_handler.lo -MD -MP -MF .deps/libfilezilla_la-event_handler.Tpo -c event_handler.cpp -o libfilezilla_la-event_handler.o >/dev/null 2>&1
1 error generated.
gmake[1]: *** [Makefile:1062: libfilezilla_la-jws.lo] Error 1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-event.lo -MD -MP -MF .deps/libfilezilla_la-event.Tpo -c event.cpp -o libfilezilla_la-event.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-impersonation.lo -MD -MP -MF .deps/libfilezilla_la-impersonation.Tpo -c impersonation.cpp -o libfilezilla_la-impersonation.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-ascii_layer.lo -MD -MP -MF .deps/libfilezilla_la-ascii_layer.Tpo -c ascii_layer.cpp -o libfilezilla_la-ascii_layer.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-local_filesys.lo -MD -MP -MF .deps/libfilezilla_la-local_filesys.Tpo -c local_filesys.cpp -o libfilezilla_la-local_filesys.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-invoker.lo -MD -MP -MF .deps/libfilezilla_la-invoker.Tpo -c invoker.cpp -o libfilezilla_la-invoker.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-iputils.lo -MD -MP -MF .deps/libfilezilla_la-iputils.Tpo -c iputils.cpp -o libfilezilla_la-iputils.o >/dev/null 2>&1
1 error generated.
gmake[1]: *** [Makefile:964: libfilezilla_la-event_loop.lo] Error 1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-hostname_lookup.lo -MD -MP -MF .deps/libfilezilla_la-hostname_lookup.Tpo -c hostname_lookup.cpp -o libfilezilla_la-hostname_lookup.o >/dev/null 2>&1
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-encode.lo -MD -MP -MF .deps/libfilezilla_la-encode.Tpo -c encode.cpp -o libfilezilla_la-encode.o >/dev/null 2>&1
mv -f .deps/libfilezilla_la-event_handler.Tpo .deps/libfilezilla_la-event_handler.Plo
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-json.lo -MD -MP -MF .deps/libfilezilla_la-json.Tpo -c json.cpp -o libfilezilla_la-json.o >/dev/null 2>&1
mv -f .deps/libfilezilla_la-event.Tpo .deps/libfilezilla_la-event.Plo
mv -f .deps/libfilezilla_la-impersonation.Tpo .deps/libfilezilla_la-impersonation.Plo
mv -f .deps/libfilezilla_la-local_filesys.Tpo .deps/libfilezilla_la-local_filesys.Plo
mv -f .deps/libfilezilla_la-invoker.Tpo .deps/libfilezilla_la-invoker.Plo
mv -f .deps/libfilezilla_la-ascii_layer.Tpo .deps/libfilezilla_la-ascii_layer.Plo
mv -f .deps/libfilezilla_la-iputils.Tpo .deps/libfilezilla_la-iputils.Plo
mv -f .deps/libfilezilla_la-hostname_lookup.Tpo .deps/libfilezilla_la-hostname_lookup.Plo
mv -f .deps/libfilezilla_la-encode.Tpo .deps/libfilezilla_la-encode.Plo
mv -f .deps/libfilezilla_la-json.Tpo .deps/libfilezilla_la-json.Plo
gmake[1]: Leaving directory '/usr/ports/ftp/libfilezilla/work/libfilezilla-0.47.0/lib'
gmake: *** [Makefile:493: all-recursive] Error 1
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[2]: stopped making "install" in /usr/ports/ftp/libfilezilla
*** Error code 1

Stop.
make[1]: stopped making "/usr/ports/ftp/filezilla/work/.install_done.filezilla._usr_local" in /usr/ports/ftp/filezilla
*** Error code 1
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2024-12-22 12:04:11 UTC
I assume that this is the build of the current version 3.67.0? And that the error is triggered by using a current clang version 19.x.x under CURRENT? Apparently this filezilla version does not work with the current clang19.

I have tried the update for filezilla in bug #283373 and bug #283374 under CURRENT with clang19 and it builds, installs and works fine. 

The remaining problem in the mentioned update is that the fetch of the distfiles does not work so far. Alternatively, you can download them manually [1][2] and store them under /usr/ports/distfiles.


[1] https://lib.filezilla-project.org/download.php
[2] https://filezilla-project.org/download.php?show_all=1
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-30 09:00:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=24d0fe9dc3b17ae496c4733e34efabad71bedcce

commit 24d0fe9dc3b17ae496c4733e34efabad71bedcce
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2024-12-30 08:52:13 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2024-12-30 08:58:43 +0000

    ftp/{lib}filezilla: update libfilezilla 0.47.0 -> 0.49.0, filezilla 3.67.0 -> 3.68.1

    - Changed Downloads to LOCAL/pi because of new download obfuscation upstream

    PR:             283371, 283373, 283374
    Author:         Martin Neubauer <m.ne@gmx.net>
    Date:           Mon Dec 30 09:52:13 2024 +0100
    Changes:        https://lib.filezilla-project.org/
                    https://filezilla-project.org/versions.php#3.68.1
    Reported-by:    andy@neu.net, rhurlin

 ftp/filezilla/Makefile                             |  5 ++-
 ftp/filezilla/distinfo                             |  6 ++--
 ftp/filezilla/pkg-plist                            |  5 +--
 ftp/libfilezilla/Makefile                          |  4 +--
 ftp/libfilezilla/distinfo                          |  6 ++--
 .../extra-patch-lib_libfilezilla_string.hpp (new)  | 42 ++++++++++++++++++++++
 ftp/libfilezilla/pkg-plist                         |  5 ++-
 7 files changed, 57 insertions(+), 16 deletions(-)
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2024-12-30 09:01:02 UTC
Fixed by updates as suggested by rhurlin
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2024-12-30 09:31:21 UTC
(In reply to Kurt Jaeger from comment #3)
I apologize for not having expressed myself clearly enough. 

The update of libfilezilla to v0.49.0 can only be built with clang19 if the additional patch (files/extra-patch-lib_libfilezilla_string.hpp) from bug #283373 is included. This patch is only used in the Makefile for clang >=191.
Comment 5 andy 2024-12-31 03:02:40 UTC
FreeBSD FBSD15 15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-n274397-f0f596bd955e: Thu Dec 19 22:15:09 EST 2024     root@FBSD15:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1500029

I see this has been closed, however it still does not work for me.  Is anyone able to build Filezilla on 15Current successfully?



# make clean
===>  Cleaning for libfilezilla-0.49.0
===>  Cleaning for filezilla-3.68.1
[root@FBSD15 /usr/ports/ftp/filezilla]# make install clean
===>  License GPLv2+ accepted by the user
===>   filezilla-3.68.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by filezilla-3.68.1 for building
===>  Extracting for filezilla-3.68.1
=> SHA256 Checksum OK for FileZilla_3.68.1_src.tar.xz.
===>  Patching for filezilla-3.68.1
...

libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-json.lo -MD -MP -MF .deps/libfilezilla_la-json.Tpo -c json.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-json.o
libtool: compile:  c++ -std=c++17 -DHAVE_CONFIG_H -I../config -DBUILDING_LIBFILEZILLA -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I. -I./libfilezilla -isystem /usr/local/include -fvisibility=hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wall -g -Werror=partial-availability -MT libfilezilla_la-invoker.lo -MD -MP -MF .deps/libfilezilla_la-invoker.Tpo -c invoker.cpp  -fPIC -DPIC -o .libs/libfilezilla_la-invoker.o
In file included from jws.cpp:1:
In file included from ./libfilezilla/encode.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/hash.hpp:111:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
  111 |           std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/hash.hpp:113:22: note: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
  113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t length, unsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
  115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
In file included from encryption.cpp:1:
In file included from ./libfilezilla/encryption.hpp:13:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,In file included from hash.cpp:1:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/hash.hpp:111:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
  111 |           std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/hash.hpp:113:22: note: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
  113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t length, unsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
  115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^

      |                                          ^
./libfilezilla/hash.hpp:111:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
  111 |           std::enable_if_t<sizeof(typename PasswordContainer::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/hash.hpp:113:22: note: while substituting prior template arguments into non-type template parameter [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>]
  113 | std::vector<uint8_t> pbkdf2_hmac_sha256(PasswordContainer const& password, SaltContainer const& salt, size_t length, unsigned int iterations)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/hash.hpp:115:9: note: while substituting deduced template arguments into function template 'pbkdf2_hmac_sha256' [with PasswordContainer = std::basic_string_view<uint8_t>, SaltContainer = std::basic_string_view<uint8_t>, $2 = (no value)]
  115 |         return pbkdf2_hmac_sha256(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(password.data()), password.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
1 error generated.
gmake[1]: *** [Makefile:979: libfilezilla_la-hash.lo] Error 1
gmake[1]: *** Waiting for unfinished jobs....
In file included from file.cpp:1:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
In file included from buffer.cpp:1:
In file included from ./libfilezilla/buffer.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
1 error generated.
gmake[1]: *** [Makefile:930: libfilezilla_la-buffer.lo] Error 1
1 error generated.
gmake[1]: *** [Makefile:972: libfilezilla_la-file.lo] Error 1
In file included from event_loop.cpp:1:
In file included from ./libfilezilla/event_loop.hpp:5:
In file included from ./libfilezilla/event.hpp:4:
In file included from ./libfilezilla/libfilezilla.hpp:7:
In file included from ./libfilezilla/string.hpp:10:
In file included from /usr/include/c++/v1/string:647:
/usr/include/c++/v1/string_view:300:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>'
  300 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
      |                                          ^
./libfilezilla/util.hpp:72:44: note: in instantiation of template class 'std::basic_string_view<unsigned char>' requested here
   72 |           std::enable_if_t<sizeof(typename First::value_type) == sizeof(uint8_t) &&
      |                                            ^
./libfilezilla/util.hpp:74:13: note: while substituting prior template arguments into non-type template parameter [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>]
   74 | inline bool equal_consttime(First const& lhs, Second const& rhs)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libfilezilla/util.hpp:76:9: note: while substituting deduced template arguments into function template 'equal_consttime' [with First = std::basic_string_view<uint8_t>, Second = std::basic_string_view<uint8_t>, $2 = (no value)]
   76 |         return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()),
      |                ^
/usr/include/c++/v1/__string/char_traits.h:45:8: note: template is declared here
   45 | struct char_traits;
      |        ^
1 error generated.
gmake[1]: *** [Makefile:944: libfilezilla_la-encryption.lo] Error 1
mv -f .deps/libfilezilla_la-event_handler.Tpo .deps/libfilezilla_la-event_handler.Plo
1 error generated.
gmake[1]: *** [Makefile:1063: libfilezilla_la-jws.lo] Error 1
mv -f .deps/libfilezilla_la-event.Tpo .deps/libfilezilla_la-event.Plo
mv -f .deps/libfilezilla_la-ascii_layer.Tpo .deps/libfilezilla_la-ascii_layer.Plo
mv -f .deps/libfilezilla_la-invoker.Tpo .deps/libfilezilla_la-invoker.Plo
mv -f .deps/libfilezilla_la-impersonation.Tpo .deps/libfilezilla_la-impersonation.Plo
mv -f .deps/libfilezilla_la-iputils.Tpo .deps/libfilezilla_la-iputils.Plo
mv -f .deps/libfilezilla_la-local_filesys.Tpo .deps/libfilezilla_la-local_filesys.Plo
1 error generated.
gmake[1]: *** [Makefile:965: libfilezilla_la-event_loop.lo] Error 1
mv -f .deps/libfilezilla_la-hostname_lookup.Tpo .deps/libfilezilla_la-hostname_lookup.Plo
mv -f .deps/libfilezilla_la-encode.Tpo .deps/libfilezilla_la-encode.Plo
mv -f .deps/libfilezilla_la-json.Tpo .deps/libfilezilla_la-json.Plo
gmake[1]: Leaving directory '/usr/ports/ftp/libfilezilla/work/libfilezilla-0.49.0/lib'
gmake: *** [Makefile:494: all-recursive] Error 1
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[2]: stopped making "install" in /usr/ports/ftp/libfilezilla
*** Error code 1

Stop.
make[1]: stopped making "/usr/ports/ftp/filezilla/work/.install_done.filezilla._usr_local" in /usr/ports/ftp/filezilla
*** Error code 1
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2024-12-31 06:09:03 UTC
(In reply to andy from comment #5)

Yeah, as I described in comment #4 of this PR, the maintainer forgot to include the patch #255954 from bug #283373 (:
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2024-12-31 08:33:34 UTC
(In reply to Rainer Hurling from comment #6)
Sorry, now I understand. The cause was that I tested on a version of 15 before clang19 was added. So for me it build successfully and I was not aware of that missing change to libfilezilla/Makefile.
Comment 8 andy 2024-12-31 18:54:43 UTC
Built and runs successfully now.