Bug 283422 - net-im/py-matrix-synapse: update to 1.123.0
Summary: net-im/py-matrix-synapse: update to 1.123.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ashish SHUKLA
URL: https://github.com/element-hq/synapse...
Keywords:
Depends on:
Blocks: 285042
  Show dependency treegraph
 
Reported: 2024-12-19 19:45 UTC by László Károlyi
Modified: 2025-03-05 09:57 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments
synapse-1.121.1.patch (6.61 KB, patch)
2024-12-19 19:45 UTC, László Károlyi
no flags Details | Diff
net-im/py-matrix-synapse: Update to 1.121.1 (17.38 KB, patch)
2024-12-30 16:16 UTC, Sascha Biberhofer
no flags Details | Diff
Update to 1.123.0. (19.52 KB, patch)
2025-01-30 14:27 UTC, Ashish SHUKLA
no flags Details | Diff
Update py-matrix-synapse to 1.125.0 (24.89 KB, patch)
2025-03-01 19:50 UTC, Sascha Biberhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2024-12-19 19:45:15 UTC
Created attachment 255958 [details]
synapse-1.121.1.patch

Attached the patch for 1.121.1.
Comment 1 Sascha Biberhofer 2024-12-30 16:16:26 UTC
Created attachment 256296 [details]
net-im/py-matrix-synapse: Update to 1.121.1

The proposed patch is fine in principle, and the bumped dependencies are consistent with the package requirements - but I'd like to go a bit further here. The patches shipped and maintained with the port here are no longer required, as we patch nothing of value with them anymore - at least as far as I can see.

I've added an updated patch that... removes both of these patches instead. The resulting port still appears to build and run perfectly fine, and passes the testsuite with flying colors (as did the proposed patch ;)):

Ran 3912 tests in 147.935s, PASSED (skips=177, successes=3735)

The resulting package is also working fine on my server. :)
Comment 2 Sascha Biberhofer 2024-12-30 16:21:24 UTC
(In reply to Sascha Biberhofer from comment #1)
A minor correction here: The original patch seems to have missed some of the updated cargo dependencies as far as I can tell (e.g. for the bytes package). The updated patch includes them, since I've manually redone the dependency bump for the patch. ;>
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2025-01-30 14:27:06 UTC
Created attachment 257122 [details]
Update to 1.123.0.

Update to 1.123.0.

Excerpt from un`it tests:


===============================================================================
[SKIPPED]
Requires jaeger_client

tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_nested_spans
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_start_active_span
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_async
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_overlapping_spans
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_awaitable_return
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_deferred
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_sync
===============================================================================
[SKIPPED]
Test only applies when postgres is used as the database

tests.storage.test_room_search.MessageSearchTest.test_postgres_web_search_for_phrase
===============================================================================
[SKIPPED]
Test is not possible because when everyone leaves the room, the server is `no_longer_in_room` and we don't have any `current_state_events` to query

tests.storage.test_roommember.RoomSummaryTestCase.test_extract_heroes_from_room_summary_fallback_leave_ban
===============================================================================
[SKIPPED]
Requires PyICU

tests.storage.test_user_directory.UserDirectoryICUTestCase.test_icu_word_boundary
tests.storage.test_user_directory.UserDirectoryICUTestCase.test_icu_word_boundary_punctuation
tests.storage.test_user_directory.UserDirectoryICUTestCase.test_regex_word_boundary_punctuation
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_all_users
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_ascii_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_start_of_user_id
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_stop_words
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_unicode_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_unicode_normalization
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_limit_correct
===============================================================================
[SKIPPED]
not supported yet

tests.storage.test_user_directory.UserDirectoryStoreTestCase.test_search_user_dir_accent_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_accent_insensitivity
===============================================================================
[SKIPPED]
not supported

tests.storage.test_user_directory.UserDirectoryStoreTestCase.test_search_user_dir_dotted_dotless_i_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_dotted_dotless_i_case_insensitivity
-------------------------------------------------------------------------------
Ran 3941 tests in 155.521s

PASSED (skips=177, successes=3764)
Comment 4 Sascha Biberhofer 2025-03-01 19:50:48 UTC
Created attachment 258164 [details]
Update py-matrix-synapse to 1.125.0

The attached patch should update net-im/py-matrix-synapse to 1.125.0 and fix the build issue reported in #285042 by reintroducing our famous pyproject.toml adjustment.

The port seems to build without issues and passes the testsuite as expected:

Ran 3969 tests in 155.330s 
PASSED (skips=177, successes=3792)

The resulting package also runs fine on my server and appears to be reasonably well-behaved after a day in operation.

Feedback and further testing is welcome as always. :)

Cheers,
Sascha
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-03-05 09:56:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f59fbc4e166b88113fecd10e9afa040d44c9ae0b

commit f59fbc4e166b88113fecd10e9afa040d44c9ae0b
Author:     Sascha Biberhofer <sascha.biberhofer@skyforge.at>
AuthorDate: 2025-03-05 09:09:59 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2025-03-05 09:53:12 +0000

    net-im/py-matrix-synapse: Update to 1.125.0

    PR:             283422

 net-im/py-matrix-synapse/Makefile                  |   7 +-
 net-im/py-matrix-synapse/Makefile.crates           |  71 +++++-----
 net-im/py-matrix-synapse/distinfo                  | 148 ++++++++++-----------
 .../py-matrix-synapse/files/patch-pyproject.toml   |  25 +---
 .../py-matrix-synapse/files/patch-setup.py (gone)  |  10 --
 5 files changed, 112 insertions(+), 149 deletions(-)
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2025-03-05 09:57:23 UTC
Committed, thanks.