Comment 1 Zsolt Udvari 2024-12-27 16:40:12 UTC

Could you please re-create your patch against current ports tree? Can't apply:

error: patch failed: benchmarks/hipercontracer/Makefile:1
error: benchmarks/hipercontracer/Makefile: patch does not apply
error: benchmarks/hipercontracer/files/pkg-deinstall.in: No such file or directory
error: benchmarks/hipercontracer/files/pkg-install.in: No such file or directory

Created attachment 257127 [details]
The diff file

The updated diff is for the latest ports tree. Also, it has been updated to the current HiPerConTracer version 2.0.2.

Comment 4 Zsolt Udvari 2025-01-31 06:20:08 UTC

(In reply to Thomas Dreibholz from comment #3)
Doesn't build:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-ping-example'
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-traceroute-example'
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-install-dependencies'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/TestDB/generate-test-certificates'
Warning: you need USES=ssl
Error: /usr/local/bin/hpct-importer is linked to /usr/local/lib/libbson-1.0.so.0 from devel/libbson but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libbson-1.0.so:devel/libbson

Comment 5 Zsolt Udvari 2025-01-31 06:22:32 UTC

And if the port needs Rscript you should add R as dependency.

Created attachment 257138 [details]
The diff file

The updated diff file should fix the dependency issue.

R is not a dependency, since Rscript is only referenced in some of the data processing examples under /usr/local/share/hipercontracer/results-examples/ .

Comment 7 Zsolt Udvari 2025-02-07 21:13:53 UTC

(In reply to Thomas Dreibholz from comment #6)
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/TestDB/generate-test-certificates'
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-traceroute-example'
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-ping-example'
Error: '/usr/bin/Rscript' is an invalid shebang you need USES=shebangfix for 'share/hipercontracer/results-examples/r-install-dependencies'

Created attachment 257601 [details]
The diff file

The updated diff file fixes the missing shebangfix settings in the Makefile. The package now also builds with the latest libboost 1.87. The build succeeds with Poudriere for 14.2-RELEASE and 15.0-CURRENT.

Comment 9 Zsolt Udvari 2025-02-24 15:30:55 UTC

Created attachment 257843 [details]
Linted Makefile

Thanks, now it builds. I format the Makefile, attaching, please use it.

About pkg-install and pkg-deinstall: you don't need it. Check "Adding Users and Groups" of Porter's Handbook [1]. You should remove these files and add user and group to /usr/ports/UIDs and GIDs.
Are the users and groups really need? As I see in README.md any user can run it.

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups

Created attachment 257845 [details]
The diif file

The updated diff fixes the issues:
* Using the updated formatting
* UIDs/GIDs updated, and files/*.in adapted. It is very useful to have these dedicated groups and user, to avoid running HiPerConTracer as regular user or even as root.

Comment 11 Zsolt Udvari 2025-02-27 14:25:45 UTC

(In reply to Thomas Dreibholz from comment #10)
I don't agree with new user and group.
As I see your examples in homepage root user should run the program (because of creating raw sockets). And if the user doesn't want root access rights while the program run can use '--user' option. As I understand you want user to '--user' option.
The package's user is designed to daemons: "Some ports require a particular user account to be present, usually for daemons that run as that user." (see [1]) - so for example the pulseaudio doesn't have root rights. And these packages has rc.d scripts to start/stop the service.

The better solution in your case would be a message after install which describes this possibility and the user can decide about new user (see [2]).

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups
[2] https://docs.freebsd.org/en/books/porters-handbook/book/#porting-message

Created attachment 258032 [details]
The diff file

The updated diff file removes the user configuration.

Comment 13 commit-hook 2025-02-27 20:23:52 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=845495b7e85ea1cac0d7774f8b6a472d253d2c26

commit 845495b7e85ea1cac0d7774f8b6a472d253d2c26
Author:     Thomas Dreibholz <thomas.dreibholz@gmail.com>
AuthorDate: 2025-02-27 20:18:34 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2025-02-27 20:23:19 +0000

    benchmarks/hipercontracer: Update to 2.0.5

    Remove BROKEN, builds fine with boost-1.86+.
    Introduce OPTIONS.
    Improve pkg-descr.
    Change maintainer's email.

    PR:             283444
    Approved by:    submitter is maintainer

 benchmarks/hipercontracer/Makefile  |  73 +++++++++++--
 benchmarks/hipercontracer/distinfo  |   6 +-
 benchmarks/hipercontracer/pkg-descr |  35 ++++++-
 benchmarks/hipercontracer/pkg-plist | 199 +++++++++++++++++++++++++++++++-----
 4 files changed, 272 insertions(+), 41 deletions(-)

Comment 14 Zsolt Udvari 2025-02-27 20:24:41 UTC

Thanks for your work! Committed.