Bug 283454 - net/freerdp3: broken with SDL=off
Summary: net/freerdp3: broken with SDL=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-20 23:32 UTC by ice
Modified: 2024-12-21 00:44 UTC (History)
0 users

See Also:
vvd: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ice 2024-12-20 23:32:00 UTC 
Broken by f88acd

This seems to fix it:

diff --git a/net/freerdp3/pkg-plist b/net/freerdp3/pkg-plist
index c9df7d39b918..965220d28c3d 100644
--- a/net/freerdp3/pkg-plist
+++ b/net/freerdp3/pkg-plist
@@ -273,8 +273,8 @@ libdata/pkgconfig/winpr-tools%%MAJORVERSION%%.pc
 libdata/pkgconfig/winpr%%MAJORVERSION%%.pc
 %%JSON%%%%KEYBOARD_LAYOUT%%share/FreeRDP/KeyboardLayoutMap.json
 %%JSON%%%%TIMEZONE_FILE%%share/WinPR/TimeZoneNameMap.json
-share/applications/sdl-freerdp%%MAJORVERSION%%-file.desktop
-share/applications/sdl-freerdp%%MAJORVERSION%%.desktop
+%%SDL%%share/applications/sdl-freerdp%%MAJORVERSION%%-file.desktop
+%%SDL%%share/applications/sdl-freerdp%%MAJORVERSION%%.desktop
 share/applications/xfreerdp%%MAJORVERSION%%-file.desktop
 share/applications/xfreerdp%%MAJORVERSION%%.desktop
 share/cmake/Modules/FreeRDP-Client%%MAJORVERSION%%/FreeRDP-ClientConfig.cmake
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-12-21 00:35:03 UTC 
Also fix if build with X11=off:
-share/applications/xfreerdp%%MAJORVERSION%%-file.desktop
-share/applications/xfreerdp%%MAJORVERSION%%.desktop
+%%X11%%share/applications/xfreerdp%%MAJORVERSION%%-file.desktop
+%%X11%%share/applications/xfreerdp%%MAJORVERSION%%.desktop
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-21 00:38:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ffdb8bbeee74c9d2f01be8fb62fb518c1e2e98c6

commit ffdb8bbeee74c9d2f01be8fb62fb518c1e2e98c6
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-12-21 00:36:51 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-12-21 00:36:51 +0000

    net/freerdp3: Fix plist if SDL=off or X11=off

    PR:     283454

 net/freerdp3/pkg-plist | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-12-21 00:44:32 UTC 
Thanks!