Bug 283502 - graphics/libcdr01: Modernize port
Summary: graphics/libcdr01: Modernize port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-23 06:07 UTC by Daniel Engberg
Modified: 2024-12-23 21:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)

Attachments
Patch for libcdr01 (1023 bytes, patch)
2024-12-23 06:07 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-12-23 06:07:07 UTC 
Created attachment 256057 [details]
Patch for libcdr01

* Remove unnecessary CPP/CXX flags
* Use USES= localbase:ldflags helper
* Adjust port Makefile to follow Porters Handbook more close

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)

Tested with following consumers in Poudriere on 14.1-RELEASE (amd64):
editors/libreoffice
graphics/inkscape
graphics/openfx-arena
print/scribus
print/scribus-devel
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2024-12-23 06:40:24 UTC 
LGTM, please feel free to commit it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-23 21:09:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e736b5a249184c47079b10646c074db08a8ddf3

commit 0e736b5a249184c47079b10646c074db08a8ddf3
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-12-23 21:02:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-12-23 21:08:39 +0000

    graphics/libcdr01: Modernize port

    * Remove unnecessary CPP/CXX flags
    * Use USES= localbase:ldflags helper
    * Adjust port Makefile to follow Porters Handbook more close

    PR:             283502
    Approved by:    office (lwhsu)

 graphics/libcdr01/Makefile | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-12-23 21:10:22 UTC 
Commmitted, thanks!