Bug 283509 - lang/ratfor: fix build on platforms where char is unsigned
Summary: lang/ratfor: fix build on platforms where char is unsigned
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-23 13:37 UTC by Robert Clausecker
Modified: 2024-12-26 10:53 UTC (History)
1 user (show)

See Also:
bofh: maintainer-feedback+
bofh: merge-quarterly+

Attachments
lang/ratfor: fix build in platforms where char is unsigned (1.53 KB, patch)
2024-12-23 13:37 UTC, Robert Clausecker 		no flags Details | Diff
lang/ratfor: fix build in platforms where char is unsigned (1.88 KB, patch)
2024-12-25 00:08 UTC, Robert Clausecker 		fuz: maintainer-approval? (bofh)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2024-12-23 13:37:43 UTC 
Created attachment 256063 [details]
lang/ratfor: fix build in platforms where char is unsigned

Turns out the code anticipates this problem and has support for using
"signed char" over "char" where "char" is unsigned by default.

Use "signed char" unconditionally to fix the port on all platforms.
This has no effect on platforms where char is already signed.

See also bug #258628.
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-12-24 04:48:04 UTC 
By any chance did you miss any additional patches/files?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-12-25 00:08:57 UTC 
Created attachment 256121 [details]
lang/ratfor: fix build in platforms where char is unsigned

Yes, indeed.  I forgot to add an edit to the makefile patch.  Please find attached a corrected patch.  I'm sorry for the inconvenience.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-12-25 00:13:23 UTC 
Of course, I'll bump PORTREVISION with this update, too, even though it should not cause any changes in behaviour on platforms where this port already builds (i.e. those where char is signed).
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2024-12-25 05:59:31 UTC 
Thanks for the updated patch. While committing can you please pet portclippy?
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-12-25 09:10:47 UTC 
Sure, will do.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-26 10:47:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=147aeb1ee48f8aeb8e4892e3271a3231388a412c

commit 147aeb1ee48f8aeb8e4892e3271a3231388a412c
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-12-25 00:07:07 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-26 10:46:28 +0000

    lang/ratfor: fix build on platforms where char is unsigned

    Turns out the code anticipates this problem and has support for using
    "signed char" over "char" where "char" is unsigned by default.

    Use "signed char" unconditionally to fix the port on all platforms.

    While we are at it, pet portclippy.

    PR:             258628, 283509
    Approved by:    bofh
    MFH:            2024Q4

 lang/ratfor/Makefile             | 17 ++++++-----------
 lang/ratfor/files/patch-Makefile |  2 +-
 2 files changed, 7 insertions(+), 12 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-12-26 10:49:40 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbe8936bd31ea5963de69b31fe6a4b494399a05a

commit dbe8936bd31ea5963de69b31fe6a4b494399a05a
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-12-25 00:07:07 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-26 10:48:40 +0000

    lang/ratfor: fix build on platforms where char is unsigned

    Turns out the code anticipates this problem and has support for using
    "signed char" over "char" where "char" is unsigned by default.

    Use "signed char" unconditionally to fix the port on all platforms.

    While we are at it, pet portclippy.

    PR:             258628, 283509
    Approved by:    bofh
    MFH:            2024Q4

    (cherry picked from commit 147aeb1ee48f8aeb8e4892e3271a3231388a412c)

 lang/ratfor/Makefile             | 17 ++++++-----------
 lang/ratfor/files/patch-Makefile |  2 +-
 2 files changed, 7 insertions(+), 12 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2024-12-26 10:53:40 UTC 
Thank you for the review.