Created attachment 256187 [details] patch to update fping Update net/fping from 5.0 to 5.2. This fixes several issues on FreeBSD. For me it was: - Fix getnameinfo not called properly for IPv4 (#227, thanks @aafbsd) - Fix "not enough sequence numbers available" error on BSD-like systems (#307, thanks @cagney, @gsnw)
Hi, Can possibly either submitter or maintainer try to work with upstream so we can get rid of our local patch? PORTREVISION can be removed if it's zero and PORTVERSION can be replaced with DISTVERSION (see Porters Handbook). Runtime tested? Tested in Poudriere? Best regards, Daniel
Created attachment 256251 [details] patch to update fping to 5.2 replaced PORTVERSION by DISTVERSION, removed PORTREVISION
(In reply to Daniel Engberg from comment #1) > so we can get rid of our local patch You mean the remaining patch ("Check that src address is one...")? This has been discussed in https://github.com/schweikert/fping/issues/206 and if I got the thing right, they introduced a new option (--check-source) which apparently fixes the issue which was the reason for this patch. But this is not in 5.2 (and 5.3 does not exist yet). > PORTREVISION can be removed if it's zero and PORTVERSION can be replaced with DISTVERSION (see Porters Handbook). Thanks for the hint, I hope the new version of the patch is OK. > Runtime tested? Tested in Poudriere? It runs without issues here on several 14.2 machines. I don't have -current or 13.x and I don't use Poudriere.
Great, think we can bump this to 5.3 since it was released a few days ago? Best regards, Daniel
Created attachment 256410 [details] patch to update fping to 5.3 I have added a new patch for upgrading to 5.3. This patch empties files/patch-fping.c assuming the issue has been fixed with the new --check-source option (see above). I cannot test this but apart from that 5.3 does what it should here. However, I only use a small subset of its features ;-). Whoever will commit this will know how to remove the now empty patch-fping.c from the repo.
Thanks, patch looks good although you might want to consider using git next time.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=eba24a3574a4c6edbcc178e9c1591f156936f7f2 commit eba24a3574a4c6edbcc178e9c1591f156936f7f2 Author: Andre Albsmeier <mail@fbsd2.e4m.org> AuthorDate: 2025-02-02 18:19:39 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2025-02-02 18:47:26 +0000 net/fping: Update to 5.3 * Replace PORTVERSION with DISTVERSION * Remove USES= autoreconf * Remove GNU_CONFIGURE_MANPREFIX * Remove patch (fixed upstream) * Adjustments to port makefile to more closely follow Porters Handbook Changelog: https://github.com/schweikert/fping/releases/tag/v5.3 Initial patch submitted by Andre Albsmeier with additions done by committer PR: 283648 Approved by: portmgr (maintainer timeout, 1+ month) net/fping/Makefile | 14 ++++++------- net/fping/distinfo | 6 +++--- net/fping/files/patch-fping.c (gone) | 39 ------------------------------------ 3 files changed, 9 insertions(+), 50 deletions(-)
Committed, thanks!