Bug 283719 - devel/ocaml-extlib: Update to 1.8.0, improve port
Summary: devel/ocaml-extlib: Update to 1.8.0, improve port
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-29 11:30 UTC by Benjamin Jacobs
Modified: 2024-12-29 15:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (eduardo)

Attachments
ocaml-extlib.patch (8.76 KB, patch)
2024-12-29 11:30 UTC, Benjamin Jacobs 		eduardo: maintainer-approval+
eduardo: maintainer-approval+
eduardo: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Jacobs 2024-12-29 11:30:51 UTC 
Created attachment 256262 [details]
ocaml-extlib.patch

Dear maintainer of ocaml-extlib,

Please provide feedback to me on the attached patch.
You do not need to commit it, it is or will be part of a larger submission to update OCaml: https://reviews.freebsd.org/D48228

Switch from USE_OCAMLFIND_PLIST to a static packing list.
Switch to USES+=ocaml:dune.
Strip shared library.
Drop undue CAMLP4 dependency.
Add test target.

Thanks in advance for your reaction,

Benjamin
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-12-29 15:05:09 UTC 
Hello Benjamin,

Could you be so kind and take maintainership on this port and devel/ocaml-cppo too?

Thanks very much
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2024-12-29 15:06:23 UTC 
(...)

If positive, I can commit the maintainership update right away.
Comment 3 Benjamin Jacobs 2024-12-29 15:16:38 UTC 
(In reply to Nuno Teixeira from comment #1)
Hello,

Yes, I'd very like to take maintainership on both of them. Thanks!
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2024-12-29 15:34:33 UTC 
I will switch maintainership now.

Related to commit this changes, what you like me to to?
Leave this PR as open and wait for resolution on review?
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-12-29 15:42:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bbd5bc45e55786b156395958693d72a22bd0dca2

commit bbd5bc45e55786b156395958693d72a22bd0dca2
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-12-29 15:39:40 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-12-29 15:39:40 +0000

    */*: Change maintainership

    Pass maintainer to Benjamin Jacobs <freebsd@dev.thsi.be>

    PR:             283719

 devel/ocaml-cppo/Makefile   | 2 +-
 devel/ocaml-extlib/Makefile | 2 +-
 devel/omake/Makefile        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2024-12-29 15:45:14 UTC 
(In reply to Benjamin Jacobs from comment #3)

I've change maintainer to you:
devel/ocaml-cppo
devel/ocaml-extlib
devel/omake

I will leave PR open to take so review can proceed fine.

Thanks very much
Comment 7 Benjamin Jacobs 2024-12-29 15:48:12 UTC 
(In reply to Nuno Teixeira from comment #4)

Yes, let's keep this ticket open until the review can proceed. Thanks!