283740 – japanese/ibus-anthy: flavorize for anthy-unicode

Bug 283740 - japanese/ibus-anthy: flavorize for anthy-unicode

Summary: japanese/ibus-anthy: flavorize for anthy-unicode

Status:	Closed FIXED

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Robert Clausecker

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-12-30 10:11 UTC by mew14930xvi
Modified:	2025-02-18 14:35 UTC (History)
CC List:	2 users (show)

See Also:

Flags:	CQG00620: maintainer-feedback+

Attachments
flavorize for anthy-unicode (1.24 KB, patch) 2024-12-30 10:11 UTC, mew14930xvi	no flags	Details \| Diff
flavorize for anthy-unicode (1.46 KB, patch) 2024-12-30 10:48 UTC, mew14930xvi	no flags	Details \| Diff
flavorize for anthy-unicode (take 2) (1.11 KB, patch) 2025-01-19 08:34 UTC, WATANABE Kazuhiro	CQG00620: maintainer-approval+	Details \| Diff
poudriere testport log on FreeBSD-current with the new patch (default flavor) (95.17 KB, text/plain) 2025-01-19 08:37 UTC, WATANABE Kazuhiro	no flags	Details
poudriere testport log on FreeBSD-current with the new patch ('unicode' flavor) (96.87 KB, text/plain) 2025-01-19 08:38 UTC, WATANABE Kazuhiro	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description mew14930xvi 2024-12-30 10:11:34 UTC

Created attachment 256292 [details]
flavorize for anthy-unicode

Comment 1 mew14930xvi 2024-12-30 10:48:05 UTC

Created attachment 256294 [details]
flavorize for anthy-unicode

Bump the revision.

Comment 2 WATANABE Kazuhiro 2025-01-19 08:30:43 UTC

Thanks for your effort!

I've rewritten your patch.

 * Use macros instead of '.if' statement.
 * Don't remove LIB_DEPENDS even if 'make stage-qa' says:

 | ====> Running Q/A tests (stage-qa)
 | Warning: you might not need LIB_DEPENDS on libibus-1.0.so

   (ja-ibus-anthy is written in Python script)

Comment 3 WATANABE Kazuhiro 2025-01-19 08:34:12 UTC

Created attachment 256791 [details]
flavorize for anthy-unicode (take 2)

To committer: would you commit the patch?

Comment 4 WATANABE Kazuhiro 2025-01-19 08:37:09 UTC

Created attachment 256792 [details]
poudriere testport log on FreeBSD-current with the new patch (default flavor)

Comment 5 WATANABE Kazuhiro 2025-01-19 08:38:32 UTC

Created attachment 256793 [details]
poudriere testport log on FreeBSD-current with the new patch ('unicode' flavor)

Comment 6 Robert Clausecker freebsd_committer

2025-02-13 18:43:42 UTC

I'm sorry for the slow processing.
Will commit with my next batch.

Comment 7 commit-hook freebsd_committer

2025-02-18 14:28:37 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eebc5fd18a9bde05875797bb9aba9c5893a6fc66

commit eebc5fd18a9bde05875797bb9aba9c5893a6fc66
Author:     WATANABE Kazuhiro <CQG00620@nifty.ne.jp>
AuthorDate: 2025-02-13 18:42:55 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-02-18 14:16:17 +0000

    japanese/ibus-anthy: flavorize for anthy-unicode

    Reported by:    mew14930xvi <mew14930xvi@inbox.lv>
    PR:             283740
    Co-authored-by: mew14930xvi <mew14930xvi@inbox.lv>

 japanese/ibus-anthy/Makefile | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

Comment 8 Robert Clausecker freebsd_committer

2025-02-18 14:35:32 UTC

Thank you for your contribution.