Bug 283748 - [PATCH] www/nginx: nginx-dav-ext-module: Fix handling for hidden files and folders
Summary: [PATCH] www/nginx: nginx-dav-ext-module: Fix handling for hidden files and fo...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-30 19:25 UTC by Bernhard Froehlich
Modified: 2025-01-22 08:45 UTC (History)
2 users (show)

See Also:
joneum: maintainer-feedback+


Attachments
nginx-dav-ext PR#62 (1.06 KB, patch)
2024-12-30 19:25 UTC, Bernhard Froehlich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Froehlich freebsd_committer freebsd_triage 2024-12-30 19:25:43 UTC
Created attachment 256297 [details]
nginx-dav-ext PR#62

Currently hidden files and folders are badly broken in the dav-ext module which I noticed when I tried to use nginx as a WebDAV backend for SeedVault (android backup). SeedVault seems to create a hidden folder where it tries to place some metadata information and that fails.

Lucky me there is already a proper fix for this in PR#62 of the upstream repository and I confirmed that it works properly for me and SeedVault backups work properly with it. \o/

https://github.com/arut/nginx-dav-ext-module/pull/62

At least AlpineLinux is also using this fix in their nginx port since 2021 (and still is).
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2025-01-21 19:02:08 UTC
LGTM :)
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-01-22 08:45:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=87fca379df1fc42dd50ac3a6d6eabf801f7ae38d

commit 87fca379df1fc42dd50ac3a6d6eabf801f7ae38d
Author:     Bernhard Froehlich <decke@FreeBSD.org>
AuthorDate: 2025-01-22 08:40:48 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2025-01-22 08:40:48 +0000

    www/nginx: Fix handling for hidden files and folders in nginx-dav-ext-module

    PR:             283748
    Approved by:    joneum@
    Obtained from:  https://github.com/arut/nginx-dav-ext-module/pull/62

 www/nginx/files/extra-patch-ngx_http_dav_ext_module.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Comment 3 Bernhard Froehlich freebsd_committer freebsd_triage 2025-01-22 08:45:04 UTC
Committed. Thanks!