Bug 283768 - graphics/povray37: build without JPEG fails
Summary: graphics/povray37: build without JPEG fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-01 13:15 UTC by Björn König
Modified: 2025-01-09 07:29 UTC (History)
2 users (show)

See Also:
bsd: maintainer-feedback+
bsd: merge-quarterly?


Attachments
graphics/povray37: Properly disable JPEG support when JPEG=off (624 bytes, patch)
2025-01-01 21:46 UTC, Philipp Ost
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Björn König 2025-01-01 13:15:02 UTC
If you try to build graphics/povray37 without JPEG support then you'll get an error message:

configure: error: cannot find a suitable JPEG library
===>  Script "configure" failed unexpectedly.

The solution is to change the line
JPEG_CONFIGURE_OFF=     --without-jpeg
to
JPEG_CONFIGURE_OFF=     --without-libjpeg
in the Makefile of the port as is also the case in graphics/povray38.
Comment 1 Philipp Ost 2025-01-01 21:46:00 UTC
Created attachment 256325 [details]
graphics/povray37: Properly disable JPEG support when JPEG=off
Comment 2 Philipp Ost 2025-01-01 21:47:30 UTC
Thanks for catching this. Even though I could not reproduce your exact error, it's wront nonetheless, as JPEG support was enabled irrespective of the setting of the JPEG option. Patch has been attached.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2025-01-09 07:29:11 UTC
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-09 07:29:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3753b094024f12048e34cc6f1248ddf0569ae931

commit 3753b094024f12048e34cc6f1248ddf0569ae931
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2025-01-07 18:32:48 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2025-01-09 07:28:32 +0000

    graphics/povray37: Fix build without JPEG

    PR:             283768
    Reported by:    freebsd@koenigbj.8bx.de

 graphics/povray37/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)