Created attachment 256381 [details] deskutils/cairo-dock-plugins.patch: Update to 3.5.1 Hi. I want to take maintainership of this port. There was a build error causing the error below in new release and i fixed it with a patch, should tell the upstream about it too. That is the error i fixed: ld-elf.so.1: /usr/local/lib/cairo-dock/libcd-Dbus.so: Undefined symbol "kvm_openfiles" Thanks in advance and happy new year!
Created attachment 256408 [details] deskutils/cairo-dock-plugins.patch: Update to 3.5.1 Added a patch fix for Dbus plugin from upstream. https://github.com/Cairo-Dock/cairo-dock-plug-ins/commit/965e01073943aa4adb84e0fdd86cf57a5a9ae935 https://github.com/Cairo-Dock/cairo-dock-plug-ins/issues/31 https://github.com/Cairo-Dock/cairo-dock-plug-ins/pull/32
Hello, This port in unmaintained, are you willing to be maintainer? Thanks
(In reply to Nuno Teixeira from comment #3) (...) Nevermind, I missed comment about maintainership. Sorry for the noise :)
(In reply to Nuno Teixeira from comment #4) No problem, thanks.
build fails under poudriere with default options: -- Checking for module 'gldi=3.5.1' -- Package dependency requirement 'gldi = 3.5.1' could not be satisfied. Package 'gldi' has version '3.5.0', required version is '= 3.5.1' CMake Error at /usr/local/share/cmake/Modules/FindPkgConfig.cmake:645 (message): The following required packages were not found: - gldi=3.5.1 Call Stack (most recent call first): /usr/local/share/cmake/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal) CMakeLists.txt:52 (pkg_check_modules) -- Configuring incomplete, errors occurred! *** Error code 1 Stop. make: stopped making "configure" in /usr/ports/deskutils/cairo-dock-plugins build of deskutils/cairo-dock-plugins | cairo-dock-plugins-3.5.1 ended at 2025-01-04T12:33:12+00:00 build time: 00:00:26 !!! build failure encountered !!! [00:19:23] Error: Build failed in phase: configure
(In reply to Nuno Teixeira from comment #6) I think it's failing because it's looking for deskutils/cairo-dock v3.5.1. Can I add something like "libgldi.so>=3.5.1:deskutils/cairo-dock" to Makefile? I also submitted an update for deskutils/cairo-dock too. Here it is: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283772 Sorry for not mentioning it, i forgot.
(In reply to Nuno Teixeira from comment #6) > Can I add something like "libgldi.so>=3.5.1:deskutils/cairo-dock" to Makefile? No, you cannot. Best procedure here is to put this PR dependent of deskutils/cairo-dock update and after it, then we proceed with this one.
(In reply to Nuno Teixeira from comment #8) Okay, thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=07071de288ab28e642800353e6ad5f2ef3ee5012 commit 07071de288ab28e642800353e6ad5f2ef3ee5012 Author: Yusuf Yaman <nxjoseph@protonmail.com> AuthorDate: 2025-01-04 22:56:20 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-01-04 23:00:30 +0000 deskutils/cairo-dock-plugins: Update to 3.5.1 - Submitter becomes maintainer Added a patch fix for Dbus plugin from upstream. See also: https://github.com/Cairo-Dock/cairo-dock-plug-ins/commit/965e01073943aa4adb84e0fdd86cf57a5a9ae935 https://github.com/Cairo-Dock/cairo-dock-plug-ins/issues/31 ChangeLog: https://github.com/Cairo-Dock/cairo-dock-plug-ins/releases/tag/3.5.1 PR: 283821 deskutils/cairo-dock-plugins/Makefile | 35 ++++++++++------------ deskutils/cairo-dock-plugins/distinfo | 6 ++-- .../files/patch-CMakeLists.txt (gone) | 22 -------------- .../files/patch-Dbus_src_CMakeLists.txt (new) | 11 +++++++ deskutils/cairo-dock-plugins/pkg-plist | 34 +++++++++++++-------- 5 files changed, 52 insertions(+), 56 deletions(-)
Committed, thanks!
(In reply to Nuno Teixeira from comment #11) You are welcome and thanks for checking.