Bug 283827 - math/polymake: Fix compilation issues with clang 19
Summary: math/polymake: Fix compilation issues with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://forum.polymake.org/viewtopic....
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-03 17:15 UTC by Philipp Ost
Modified: 2025-01-06 23:12 UTC (History)
1 user (show)

See Also:
bsd: maintainer-feedback+
bsd: maintainer-feedback+
bsd: merge-quarterly?

Attachments
math/polymake: fix compilation errors with clang 19 (18.37 KB, patch)
2025-01-03 17:15 UTC, Philipp Ost 		bsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2025-01-03 17:15:15 UTC 
Created attachment 256384 [details]
math/polymake: fix compilation errors with clang 19

As reported by pkg-fallout, polymake fails to compile with clang 19 (c.f. Bug 283780). The attached set of patches, courtesy of Benjamin Lorenz, fixes these issues.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2025-01-04 18:20:08 UTC 
Would you like for these changes to be merged into the quarterly branch?  If yes, please set the "merge-quarterly" flag.
Comment 2 Philipp Ost 2025-01-04 18:23:52 UTC 
(In reply to Robert Clausecker from comment #1)
Yes, that would be great. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-01-06 23:08:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b9a02d30092fd9f590b4cd38a80ca3cc46ffca03

commit b9a02d30092fd9f590b4cd38a80ca3cc46ffca03
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2025-01-04 18:19:36 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-01-06 23:06:15 +0000

    math/polymake: fix build with clang 19

    PR:             283827
    MFH:            2025Q1
    Obtained from:  https://forum.polymake.org/viewtopic.php?p=4159

 math/polymake/Makefile                             |   1 +
 ...h-external_permlib_include_permlib_bsgs.h (new) |  11 ++
 ...e_permlib_predicate_identity__predicate.h (new) |  11 ++
 ...dicate_pointwise__stabilizer__predicate.h (new) |  11 ++
 ..._predicate_stabilizes__point__predicate.h (new) |  11 ++
 ...e_permlib_predicate_subgroup__predicate.h (new) |  11 ++
 ..._search_partition_backtrack__refinement.h (new) |  11 ++
 ...lib_include_permlib_sorter_base__sorter.h (new) |  11 ++
 ...ib_include_permlib_sorter_group__sorter.h (new) |  11 ++
 ..._include_permlib_sorter_trivial__sorter.h (new) |  11 ++
 .../patch-lib_core_include_ContainerChain.h (new)  | 131 +++++++++++++++++++++
 .../patch-lib_core_include_GenericMatrix.h (new)   |  17 +++
 ...b_core_include_internal_pool__allocator.h (new) |  14 +++
 .../files/patch-lib_core_include_optional (new)    |  38 ++++++
 14 files changed, 300 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-06 23:09:18 UTC 
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ddbea205b972cfd8d7f1128a0e5bc86b9217766

commit 9ddbea205b972cfd8d7f1128a0e5bc86b9217766
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2025-01-04 18:19:36 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-01-06 23:08:04 +0000

    math/polymake: fix build with clang 19

    PR:             283827
    MFH:            2025Q1
    Obtained from:  https://forum.polymake.org/viewtopic.php?p=4159

    (cherry picked from commit b9a02d30092fd9f590b4cd38a80ca3cc46ffca03)

 math/polymake/Makefile                             |   1 +
 ...h-external_permlib_include_permlib_bsgs.h (new) |  11 ++
 ...e_permlib_predicate_identity__predicate.h (new) |  11 ++
 ...dicate_pointwise__stabilizer__predicate.h (new) |  11 ++
 ..._predicate_stabilizes__point__predicate.h (new) |  11 ++
 ...e_permlib_predicate_subgroup__predicate.h (new) |  11 ++
 ..._search_partition_backtrack__refinement.h (new) |  11 ++
 ...lib_include_permlib_sorter_base__sorter.h (new) |  11 ++
 ...ib_include_permlib_sorter_group__sorter.h (new) |  11 ++
 ..._include_permlib_sorter_trivial__sorter.h (new) |  11 ++
 .../patch-lib_core_include_ContainerChain.h (new)  | 131 +++++++++++++++++++++
 .../patch-lib_core_include_GenericMatrix.h (new)   |  17 +++
 ...b_core_include_internal_pool__allocator.h (new) |  14 +++
 .../files/patch-lib_core_include_optional (new)    |  38 ++++++
 14 files changed, 300 insertions(+)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-01-06 23:12:16 UTC 
Thank you for your submission.