Created attachment 256442 [details] editors/gobby.patch: Update to 0.6.0 Hi. I want to take maintainership of this port. Thanks in advance.
Created attachment 256443 [details] editors/gobby.patch: Update to 0.6.0 and remove deprecated options Removed deprecated options
Created attachment 256452 [details] editors/gobby.patch: Update to 0.6.0 Added some of LIB_DEPENDS to available USE_GNOME. Remove cpe useflag as it seem unnecessary. Rename manpage and binaries without version number. Here is the diff (attached patch is whole patch) diff --git a/editors/gobby/Makefile b/editors/gobby/Makefile index 2c7dde337e74..2fe07f0c61e7 100644 --- a/editors/gobby/Makefile +++ b/editors/gobby/Makefile @@ -11,28 +11,27 @@ LICENSE= ISCL LICENSE_FILE= ${WRKSRC}/COPYING BUILD_DEPENDS= itstool:textproc/itstool -LIB_DEPENDS= libatkmm-1.6.so:accessibility/atkmm \ - libcairomm-1.0.so:graphics/cairomm \ - libgiomm-2.4.so:devel/glibmm \ - libglibmm-2.4.so:devel/glibmm \ - libgnutls.so:security/gnutls \ +LIB_DEPENDS= libgnutls.so:security/gnutls \ libgsasl.so:security/libgsasl \ - libgtkmm-3.0.so:x11-toolkits/gtkmm30 \ - libgtksourceview-3.0.so:x11-toolkits/gtksourceview3 \ libinfgtk-0.7.so:textproc/libinfinity \ libinfinity-0.7.so:textproc/libinfinity \ libinftext-0.7.so:textproc/libinfinity \ - libinftextgtk-0.7.so:textproc/libinfinity \ - libpangomm-1.4.so:x11-toolkits/pangomm \ - libsigc-2.0.so:devel/libsigc++20 \ - libxml++-2.6.so:textproc/libxml++26 + libinftextgtk-0.7.so:textproc/libinfinity -USES= compiler:c++11-lang cpe desktop-file-utils gettext gmake gnome \ +USES= compiler:c++11-lang desktop-file-utils gettext gmake gnome \ pathfix pkgconfig -CPE_VENDOR= ${PORTNAME}_project USE_CXXSTD= c++11 -USE_GNOME= gtksourceview3 intltool +USE_GNOME= atkmm cairomm glibmm gtkmm30 gtksourceview3 intltool \ + libsigc++20 libxml++26 pangomm GNU_CONFIGURE= yes +post-install: + @cd ${STAGEDIR}${PREFIX}/bin && \ + ${MV} gobby-0.5 \ + gobby + @cd ${STAGEDIR}${PREFIX}/share/man/man1 && \ + ${MV} gobby-0.5.1 \ + gobby.1 + .include <bsd.port.mk> diff --git a/editors/gobby/pkg-plist b/editors/gobby/pkg-plist index dc7d11be3d82..061bb4e2f3f1 100644 --- a/editors/gobby/pkg-plist +++ b/editors/gobby/pkg-plist @@ -1,4 +1,4 @@ -bin/gobby-0.5 +bin/gobby share/applications/gobby-0.5.desktop share/glib-2.0/schemas/de.0x539.gobby.gschema.xml %%DATADIR%%-0.5/icons/HighContrastLargePrint/48x48/actions/chat.png @@ -43,5 +43,5 @@ share/locale/it_IT/LC_MESSAGES/gobby05.mo share/locale/ja/LC_MESSAGES/gobby05.mo share/locale/pt_BR/LC_MESSAGES/gobby05.mo share/locale/zh_TW/LC_MESSAGES/gobby05.mo -share/man/man1/gobby-0.5.1.gz +share/man/man1/gobby.1.gz share/metainfo/gobby-0.5.metainfo.xml
Created attachment 256461 [details] editors/gobby.patch: Update to 0.6.0 Changed gtkmm version. I noticed that I didn't put correct gtkmm version while switching depends to USE_GNOME. diff --git a/editors/gobby/Makefile b/editors/gobby/Makefile index 2fe07f0c61e7..bb0c79c18c56 100644 --- a/editors/gobby/Makefile +++ b/editors/gobby/Makefile @@ -21,7 +21,7 @@ LIB_DEPENDS= libgnutls.so:security/gnutls \ USES= compiler:c++11-lang desktop-file-utils gettext gmake gnome \ pathfix pkgconfig USE_CXXSTD= c++11 -USE_GNOME= atkmm cairomm glibmm gtkmm30 gtksourceview3 intltool \ +USE_GNOME= atkmm cairomm glibmm gtkmm24 gtksourceview3 intltool \ libsigc++20 libxml++26 pangomm GNU_CONFIGURE= yes
Created attachment 256462 [details] editors/gobby.patch: Update to 0.6.0 (In reply to Yusuf Yaman from comment #4) I did revert this patch because it should use gtkmm30, i'm confused and mixed it with glibmm, sorry.
Did a quick search in mac ports: # configure: error: *** A compiler with support for C++11 language features is required. compiler.cxx_standard 2011 and tested our port without USE_CXXSTD=c++11 and fails. Lets ship it that way.
(In reply to Nuno Teixeira from comment #6) Thanks for the information. Could you please provide a link to me about "mac ports"?
Previous version has NLS option. Could you put it to work? While this is optional we should use it when available/supportable: https://docs.freebsd.org/en/books/porters-handbook/book/#using-gettext-optional Starting run-testing...
(In reply to Yusuf Yaman from comment #7) https://github.com/macports/macports-ports/blob/master/x11/gobby/Portfile
(In reply to Nuno Teixeira from comment #8) I will try adding it. (In reply to Nuno Teixeira from comment #9) Thanks for sharing.
Created attachment 256474 [details] editors/gobby.patch I added NLS option back, thanks.
diff --git a/editors/gobby/Makefile b/editors/gobby/Makefile index 2fe07f0c61e7..9afc4b0d75cb 100644 --- a/editors/gobby/Makefile +++ b/editors/gobby/Makefile @@ -18,14 +18,20 @@ LIB_DEPENDS= libgnutls.so:security/gnutls \ libinftext-0.7.so:textproc/libinfinity \ libinftextgtk-0.7.so:textproc/libinfinity -USES= compiler:c++11-lang desktop-file-utils gettext gmake gnome \ - pathfix pkgconfig +USES= compiler:c++11-lang desktop-file-utils gmake gnome pathfix \ + pkgconfig USE_CXXSTD= c++11 USE_GNOME= atkmm cairomm glibmm gtkmm30 gtksourceview3 intltool \ libsigc++20 libxml++26 pangomm GNU_CONFIGURE= yes +OPTIONS_DEFINE= NLS +OPTIONS_SUB= yes + +NLS_USES= gettext +NLS_CONFIGURE_ENABLE= nls + post-install: @cd ${STAGEDIR}${PREFIX}/bin && \ ${MV} gobby-0.5 \ diff --git a/editors/gobby/pkg-plist b/editors/gobby/pkg-plist index 061bb4e2f3f1..2bd6026a22d0 100644 --- a/editors/gobby/pkg-plist +++ b/editors/gobby/pkg-plist @@ -34,14 +34,14 @@ share/icons/HighContrastLargePrintInverse/48x48/apps/gobby-0.5.png share/icons/HighContrastLargePrintInverse/scalable/apps/gobby-0.5.svg share/icons/hicolor/48x48/apps/gobby-0.5.png share/icons/hicolor/scalable/apps/gobby-0.5.svg -share/locale/ca/LC_MESSAGES/gobby05.mo -share/locale/de/LC_MESSAGES/gobby05.mo -share/locale/el_GR/LC_MESSAGES/gobby05.mo -share/locale/en_GB/LC_MESSAGES/gobby05.mo -share/locale/fr/LC_MESSAGES/gobby05.mo -share/locale/it_IT/LC_MESSAGES/gobby05.mo -share/locale/ja/LC_MESSAGES/gobby05.mo -share/locale/pt_BR/LC_MESSAGES/gobby05.mo -share/locale/zh_TW/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/ca/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/de/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/el_GR/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/en_GB/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/fr/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/it_IT/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/ja/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/pt_BR/LC_MESSAGES/gobby05.mo +%%NLS%%share/locale/zh_TW/LC_MESSAGES/gobby05.mo share/man/man1/gobby.1.gz share/metainfo/gobby-0.5.metainfo.xml
(In reply to Yusuf Yaman from comment #12) gettext is deprecated, it will be gettext-{runtime,tools}. Build with NLS OFF still requires gettext-tools to build OK, so I will include it in global USES. I'll commit with changes.
(In reply to Nuno Teixeira from comment #13) Oh, I see, thanks. I wish I could use poudriere to test my ports without needing to compile all other dependencies. It would be better for me to diagnose problems myself.
(In reply to Yusuf Yaman from comment #14) When there are too many deps to compile, you can use `-b latest|quarterly` to download them from repository. This is what I do in releases. In main, I build everything :)
(In reply to Nuno Teixeira from comment #15) Thanks, I already know the -b option but most of the time it doesn't work for me, maybe it's because port version mismatches between the FreeBSD latest repository and my latest ports tree.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bfbb316cca580cffbb74bfd57e5cd146634786c7 commit bfbb316cca580cffbb74bfd57e5cd146634786c7 Author: Yusuf Yaman <nxjoseph@protonmail.com> AuthorDate: 2025-01-06 17:00:31 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-01-06 17:04:40 +0000 editors/gobby: Update to 0.6.0 - Switch from PORTVERSION to DISTVERSION - Update LICENSE - Remove extinct GTKSPELL option - Submitter becomes maintainer ChangeLog: https://github.com/gobby/gobby/blob/v0.6.0/NEWS PR: 283864 editors/gobby/Makefile | 65 +++++++------- editors/gobby/distinfo | 5 +- editors/gobby/files/patch-inc__config.hpp (gone) | 38 --------- .../files/patch-inc__preferencesdialog.hpp (gone) | 11 --- editors/gobby/pkg-descr | 6 +- editors/gobby/pkg-plist | 98 ++++++++++------------ 6 files changed, 82 insertions(+), 141 deletions(-)
BTW, future 0.7.0 version seems promising regarding build tool: https://github.com/gobby/gobby/blob/0f8182ed3ae7e65b1a1ebd58fdb0a47df92b2cbb/NEWS#L5 Committed, thanks!
(In reply to Nuno Teixeira from comment #18) Yes. You are welcome and many thanks.