Bug 283966 - devel/llvm16: compiling on 15-CURRENT fail: integer.h:310:32: error: a template argument list is expected after a name prefixed by the template keyword
Summary: devel/llvm16: compiling on 15-CURRENT fail: integer.h:310:32: error: a templa...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-09 20:26 UTC by O. Hartmann
Modified: 2025-03-17 18:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2025-01-09 20:26:04 UTC
Try to compile port devel/llvm16 on recent CURRENT (FreeBSD 15.0-CURRENT #35 main-n274635-7f8f120439b7: Wed Jan  8 06:33:48 CET 2025), compiling fails due to error shown below:

[...]
In file included from /usr/ports/devel/llvm16/work-default/llvm-project-16.0.6.src/flang/include/flang/Evaluate/real.h:13:
/usr/ports/devel/llvm16/work-default/llvm-project-16.0.6.src/flang/include/flang/Evaluate/integer.h:310:32: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  310 |       auto back{FROM::template ConvertSigned(result.value)};
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-01-10 00:43:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9592edb43243a6a2bdef59c99a69e5a309df910f

commit 9592edb43243a6a2bdef59c99a69e5a309df910f
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-01-10 00:35:34 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-01-10 00:42:12 +0000

    devel/llvm16: backport flang fixes for llvm19

    The FLANG option is off by default so this wasn't noted in the llvm19
    import.  Backport 7bc7672925f81 from upstream LLVM.

    The patches to fold-real.cpp and reduction-templates.h were hand
    applied.

    PR:             283966
    Reported by:    ohartmann@walstatt.org

 .../files/patch-backport-7bc7672925f81 (new)       | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2025-01-10 00:54:44 UTC
I've verified this builds with llvm18, but don't currently have an easy way to test with 19 so please let me know if it's sufficient.
Comment 3 O. Hartmann 2025-01-10 04:52:44 UTC
Thank you very much.
Comment 4 O. Hartmann 2025-01-10 04:55:12 UTC
(In reply to Brooks Davis from comment #2)

Sorry, I didn't realised that FLANG has been selected. We use this option in very rare cases. The leftover selection on LLVM16 triggered the error. I can only speak for myself - it is not that important. Thanks anyway for fixing in LLVM16.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-03-14 00:57:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=092b9a234522e403db69de50bb04c34b6f12c709

commit 092b9a234522e403db69de50bb04c34b6f12c709
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-03-12 16:58:24 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-03-14 00:56:39 +0000

    devel/llvm18: backport llvm19 fixes

    Pull in the patch from llvm1[567] and manually patch fold-logical.cpp
    (there's nothing sensible to back port because the offending code was
    rewritten in a commit that doesn't apply easily between 18 and 19.)

    PR:             283966, 285195
    Submitted by:   milios@ccsys.com (fixed backport patch)

 .../files/patch-backport-7bc7672925f81 (new)       | 76 ++++++++++++++++++++++
 ...patch-flang_lib_Evaluate_fold-logical.cpp (new) | 29 +++++++++
 2 files changed, 105 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-03-14 00:57:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=62739e5a874c4114b4e049dbbd655e7f88c017a3

commit 62739e5a874c4114b4e049dbbd655e7f88c017a3
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-01-10 00:35:34 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-03-14 00:56:38 +0000

    devel/llvm17: backport flang fixes for llvm19

    The FLANG option is off by default so this wasn't noted in the llvm19
    import.  Backport 7bc7672925f81 from upstream LLVM.

    The patches to fold-real.cpp and reduction-templates.h were hand
    applied.

    PR:             283966, 285195
    Reported by:    ohartmann@walstatt.org
    Submitted by:   milios@ccsys.com

 .../files/patch-backport-7bc7672925f81 (new)       | 76 ++++++++++++++++++++++
 1 file changed, 76 insertions(+)
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-03-17 18:38:50 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48d88a1daa6bffcfe8cf571e69c844d3787c4d4c

commit 48d88a1daa6bffcfe8cf571e69c844d3787c4d4c
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-03-12 16:58:24 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-03-17 18:38:09 +0000

    devel/llvm18: backport llvm19 fixes

    Pull in the patch from llvm1[567] and manually patch fold-logical.cpp
    (there's nothing sensible to back port because the offending code was
    rewritten in a commit that doesn't apply easily between 18 and 19.)

    PR:             283966, 285195
    Submitted by:   milios@ccsys.com (fixed backport patch)

    (cherry picked from commit 092b9a234522e403db69de50bb04c34b6f12c709)

 .../files/patch-backport-7bc7672925f81 (new)       | 76 ++++++++++++++++++++++
 ...patch-flang_lib_Evaluate_fold-logical.cpp (new) | 29 +++++++++
 2 files changed, 105 insertions(+)
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-03-17 18:39:31 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a13ba037fcd08370dccabc65b7fea0357c6b541

commit 4a13ba037fcd08370dccabc65b7fea0357c6b541
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-01-10 00:35:34 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-03-17 18:38:06 +0000

    devel/llvm16: backport flang fixes for llvm19

    The FLANG option is off by default so this wasn't noted in the llvm19
    import.  Backport 7bc7672925f81 from upstream LLVM.

    The patches to fold-real.cpp and reduction-templates.h were hand
    applied.

    PR:             283966
    Reported by:    ohartmann@walstatt.org

    (cherry picked from commit 9592edb43243a6a2bdef59c99a69e5a309df910f)

 .../files/patch-backport-7bc7672925f81 (new)       | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-03-17 18:39:34 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c9c675ac883eb714c97f4b25491988e845cb47f

commit 8c9c675ac883eb714c97f4b25491988e845cb47f
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-01-10 00:35:34 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-03-17 18:38:09 +0000

    devel/llvm17: backport flang fixes for llvm19

    The FLANG option is off by default so this wasn't noted in the llvm19
    import.  Backport 7bc7672925f81 from upstream LLVM.

    The patches to fold-real.cpp and reduction-templates.h were hand
    applied.

    PR:             283966, 285195
    Reported by:    ohartmann@walstatt.org
    Submitted by:   milios@ccsys.com

    (cherry picked from commit 62739e5a874c4114b4e049dbbd655e7f88c017a3)

 .../files/patch-backport-7bc7672925f81 (new)       | 76 ++++++++++++++++++++++
 1 file changed, 76 insertions(+)