Bug 283977 - net-mgmt/nagios: Adding monplugins flavor to nagios
Summary: net-mgmt/nagios: Adding monplugins flavor to nagios
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-10 10:26 UTC by Xavier Beaudouin
Modified: 2025-01-30 15:47 UTC (History)
1 user (show)

See Also:
joneum: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin freebsd_committer freebsd_triage 2025-01-10 10:26:58 UTC 
Some users asked to add a flavor to permit to have nagios already
packaged with monplugins.
This patch add this functionality and has been tested (both flavors
default and monplugins) with poudriere under 13.4-RELEASE.

Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2025-01-13 20:09:00 UTC 
Hey Xavier,

thanks for the PR.
Did you forget to upload the patch, I don't see one ;-)

Cheers
Jochen
Comment 2 Xavier Beaudouin freebsd_committer freebsd_triage 2025-01-20 10:26:35 UTC 
(In reply to Jochen Neumeister from comment #1)
Hello Jochen,

As a new port commiter I have uploaded patch into Phabricator, please see : https://reviews.freebsd.org/D48146

Would you like I upload the patch here as well ?

Kind regards,
Xavier
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2025-01-28 21:53:30 UTC 
(In reply to Xavier Beaudouin from comment #2)


Hey Xavier, no, the link is okay.
Looks ok for me, you can commit it. 

thx for youre work :-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-30 12:51:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0fb561611ee8da2f56b4241315e214a79b69943c

commit 0fb561611ee8da2f56b4241315e214a79b69943c
Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
AuthorDate: 2024-12-19 12:16:06 +0000
Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
CommitDate: 2025-01-30 12:50:07 +0000

    net-mgmt/nagios: Add monplugins flavor

    Some users asked to add a flavor to permit to have nagios already
    packaged with monplugins.

    PR:     283977
    Sponsored by:   Klara, Inc.
    Approved by:    0mp (mentor)
    Approved by:    joneum (maintainer)
    Differential Revision:  https://reviews.freebsd.org/D48146

 net-mgmt/nagios/Makefile | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
Comment 5 Xavier Beaudouin freebsd_committer freebsd_triage 2025-01-30 15:47:33 UTC 
Patch has been committed !
Thanks !