Bug 284125 - science/orthanc: Update to 1.12.6
Summary: science/orthanc: Update to 1.12.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks: 284698
  Show dependency treegraph
 
Reported: 2025-01-18 00:21 UTC by fullermd
Modified: 2025-02-16 21:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (maintainer.freebsd)


Attachments
Update to 1.12.5 (10.00 KB, patch)
2025-01-18 00:21 UTC, fullermd
no flags Details | Diff
Update to 1.12.6 (11.21 KB, patch)
2025-02-09 22:25 UTC, fullermd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fullermd 2025-01-18 00:21:27 UTC
Created attachment 256766 [details]
Update to 1.12.5

This updates to the current release, which unbreaks build with current boost.

Not deeply tested, but builds and packages cleanly.  This doesn't help the build of the other science/orthanc*'s much, but it's a step...
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-01 21:17:24 UTC
How did you build it ?

Testbuild fails with:

DCMTK version: 369
CMake Error at /wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.12.5/OrthancFramework/Resources/CMake/DcmtkConfiguration.cmake:312 (message):
  Cannot locate the DICOM dictionary on this system
Call Stack (most recent call first):
  /wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.12.5/OrthancFramework/Resources/CMake/OrthancFrameworkConfiguration.cmake:523 (include)
  CMakeLists.txt:80 (include)
Comment 2 fullermd 2025-02-01 22:14:43 UTC
(In reply to Kurt Jaeger from comment #1)

Nothing too special, just built the port/package out of the git tree I was working on (after manually installing the missing dependancies).

I'll try and check into it sometime this coming week, if I don't get beat to it.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-02 07:56:58 UTC
(In reply to fullermd from comment #2)
Try a test build in poudriere. This tries to make sure you have a clean build.
Comment 4 fullermd 2025-02-09 22:24:37 UTC
OK, looks like the graphics/dcmtk update is what broke it, since the paths are versioned.  Regenning with that made explicit, a protobuf build fix (may be new, I gave up trying to track the changes), and a bump to 1.12.6.
Comment 5 fullermd 2025-02-09 22:25:10 UTC
Created attachment 257366 [details]
Update to 1.12.6
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-13 18:31:01 UTC
testbuilds@work
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-14 06:31:55 UTC
(In reply to Kurt Jaeger from comment #6)
Another test of build with boost 1.87
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-14 18:59:59 UTC
(In reply to Kurt Jaeger from comment #7)
Builds, seems to run. I'm too stupid (ahem, impation) to get it do more than just
request basic-auth and not accept any user/pw 8-(
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-02-15 13:51:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aef2bd602f5e9d27eeadfd91e85cffd97934533b

commit aef2bd602f5e9d27eeadfd91e85cffd97934533b
Author:     Matthew D. Fuller <fullermd@over-yonder.net>
AuthorDate: 2025-02-15 13:46:30 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2025-02-15 13:50:40 +0000

    science/orthanc: update 1.12.3 -> 1.12.6

    - unbreak, 1.12.3 was broken by boost update

    PR:             284125

 science/orthanc/Makefile                                     |  9 ++++-----
 science/orthanc/distinfo                                     |  6 +++---
 ...hancFramework_Resources_CMake_CivetwebConfiguration.cmake |  4 ++--
 ...hancFramework_Resources_CMake_ProtobufConfiguration.cmake |  4 ++--
 .../patch-OrthancFramework_Sources_Images_JpegWriter.cpp     | 12 ++++++------
 .../files/patch-OrthancFramework_Sources_OrthancFramework.h  |  4 ++--
 .../patch-OrthancFramework_Sources_SystemToolbox.cpp (gone)  | 11 -----------
 ...ch-OrthancServer_Plugins_Engine_PluginsManager.cpp (gone) | 11 -----------
 ...erver_Plugins_Samples_ModalityWorklists_Plugin.cpp (gone) | 11 -----------
 .../files/patch-OrthancServer_Resources_Configuration.json   |  4 ++--
 ...tch-OrthancServer_Sources_OrthancConfiguration.cpp (gone) | 11 -----------
 11 files changed, 21 insertions(+), 66 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2025-02-16 19:04:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=795659cacf1d39df47e6f6b9bcd3ba804a1d4069

commit 795659cacf1d39df47e6f6b9bcd3ba804a1d4069
Author:     Matthew D. Fuller <fullermd@over-yonder.net>
AuthorDate: 2025-02-16 19:03:08 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2025-02-16 19:03:08 +0000

    science/orthanc: add changes

    - move the comment line to the CMAKE_ARGS line
    - change absolut path to LOCALBASE

    PR:     284125
    Reported by: vvd, fullermd@over-yonder.net

 science/orthanc/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2025-02-16 19:05:51 UTC
Fixed, thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2025-02-16 21:05:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8098887d0c2d76b93b21ba0827fac96bb33a9667

commit 8098887d0c2d76b93b21ba0827fac96bb33a9667
Author:     Matthew D. Fuller <fullermd@over-yonder.net>
AuthorDate: 2025-02-16 21:03:44 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2025-02-16 21:03:44 +0000

    science/orthanc: add missing file

    PR:     284125

 ...patch-OrthancServer_Sources_OrthancInitialization.cpp (new) | 10 ++++++++++
 1 file changed, 10 insertions(+)