Bug 284205 - german/tipp10: update 3.3.0 -> 3.3.2
Summary: german/tipp10: update 3.3.0 -> 3.3.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://gitlab.com/tipp10/tipp10/-/tags
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-20 19:31 UTC by Älven
Modified: 2025-02-11 13:33 UTC (History)
3 users (show)

See Also:
nick.lott: maintainer-feedback+


Attachments
[PATCH] german/tipp10: update 3.3.0 → 3.3.2 (13.04 KB, patch)
2025-01-20 19:31 UTC, Älven
nick.lott: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2025-01-20 19:31:44 UTC
Created attachment 256854 [details]
[PATCH] german/tipp10: update 3.3.0 → 3.3.2
Comment 1 Nick Lott 2025-02-01 23:38:42 UTC
Looks good to me I'll confirm it builds for me and let you know.
Comment 2 Nick Lott 2025-02-02 00:45:27 UTC
Builds for me and operates as expected.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2025-02-05 16:12:11 UTC
Älven, please avoid the unicode character → in your commit message.  It triggers a bug in the script that converts commits to emails.
Comment 4 Älven 2025-02-05 16:38:41 UTC
(In reply to Robert Clausecker from comment #3)

Then it's the script that should be fixed: Unicode is here to stay and is used in committers' names already.
I saw it being successfully used [0] by Yuri Victorovich (@yuri) and some other committers without anyone trying to stop them to do so.

[0] https://www.freshports.org/misc/llama-cpp/
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-05 16:49:32 UTC
(In reply to Älven from comment #4)

Hi Älven,

There's a thread on the ports mailing list about this right now.  Please read it.
Yes, Unicode is supported.  But Unicode in the subject line specifically causes
problems right now.  Plus we have a bunch of developers who run their systems in
non-Unicode locales, so they only get weird replacement characters.

Please follow the guidance and use -> over →.  Or just leave out the old version from the subject line, it does not add anything of value.
Comment 6 Älven 2025-02-05 20:17:08 UTC
(In reply to Robert Clausecker from comment #5)

Hi Robert,

Thank you for the explanation. I'm sorry I was too strict with my first answer to you: I likely was wrong taking this personally as I see now you are not against me.

Actually I have no serious reasons to strictly prefer one symbol or another, I may and will use whatever looks good enough. Well, let it be ->, OK.

> Or just leave out the old version from the subject line, it does not add anything of value.

I just can't agree with you on this: I clearly see an important value in the possibility to quickly estimate the version distance between old and new ones, as this makes a big difference between patch level, minor or major versions upgrades, especially if there were several intermediate versions missed from gradual upgrade, jumping over to the most recent one. It's linked to the expected amount of changes needed and the level of checking during update: patch/minor I usually just version bump with little check, while major ones may need revision of dependencies, pre/post-install or even pkg-descr, etc.

I liked this style from the first time I saw it and would like to continue to use it.
Comment 7 Älven 2025-02-07 00:17:22 UTC
(In reply to Robert Clausecker from comment #5)
> There's a thread on the ports mailing list about this right now.  Please read it.

Sorry, I can't find it in mail list archives. Could you, please, give a http:// link for it?
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2025-02-07 13:50:49 UTC
(In reply to Älven from comment #7)

Apparently the thread is on developers@, the internal mailing list for committers.  I am not permitted to share things from that list with you unfortunately, you just need to trust me with this one.
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-02-11 13:27:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=173acb756eb05adb75ace03d8591b9d8d0e16aa8

commit 173acb756eb05adb75ace03d8591b9d8d0e16aa8
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2025-01-19 23:45:44 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-02-11 13:26:12 +0000

    german/tipp10: update to 3.3.2

    + Add education to CATEGORIES
    + Add WWW for source code repository
    * Replace hardcoded path with %%DATADIR%% macro in pkg-plist
    * Sort USES and pkg-plist

    PR:             284205
    Approved by:    nick.lott@gmail.com (maintainer)

 german/tipp10/Makefile  |  11 ++-
 german/tipp10/distinfo  |   6 +-
 german/tipp10/pkg-plist | 257 ++++++++++++++++++++++++++++--------------------
 3 files changed, 162 insertions(+), 112 deletions(-)
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2025-02-11 13:33:01 UTC
Thank you for your contribution.