Bug 284274 - print/lyx pkg-plist incorrect if NLS is disabled
Summary: print/lyx pkg-plist incorrect if NLS is disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-22 20:48 UTC by Edward.Sanford.Sutton, III
Modified: 2025-01-24 01:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
Insert %%NLS%% at start of relevant filenames (2.41 KB, patch)
2025-01-22 20:48 UTC, Edward.Sanford.Sutton, III
no flags Details | Diff
Insert NLS variable on relevant pkg-plist lines. Git friendly version of previous patch (2.83 KB, patch)
2025-01-22 22:49 UTC, Edward.Sanford.Sutton, III
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Edward.Sanford.Sutton, III 2025-01-22 20:48:56 UTC
Created attachment 256915 [details]
Insert %%NLS%% at start of relevant filenames

The pkg-plist doesn't conditionally stop listing files based on NLS definition; prepending %%NLS%% to lines starting with share/locale/ corrects that. Build failure found with OPTIONS_UNSET+=NLS defined in make.conf during a poudriere run.

=======================<phase: package        >============================
===== env: 'PKG_NOTES=build_timestamp ports_top_git_hash ports_top_checkout_unclean port_git_hash port_checkout_unclean built_by' 'PKG_NOTE_build_timestamp=2025-01-22T02:01:10+00:00' 'PKG_NOTE_ports_top_git_hash=37b63b66d301' 'PKG_NOTE_ports_top_checkout_unclean=no' 'PKG_NOTE_port_git_hash=312ee18b022b' 'PKG_NOTE_port_checkout_unclean=no' 'PKG_NOTE_built_by=poudriere-git-3.4.99.20250115' NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Building packages for lyx-2.4.2_1
===>   Building lyx-2.4.2_1
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/ar/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/bg/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/cs/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/de/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/en/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/es/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/eu/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/fi/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/fr/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/he/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/hu/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/ia/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/id/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/it/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/ja/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/nb/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/nl/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/nn/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/pl/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/pt_BR/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/pt_PT/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/ru/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/sk/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/sv/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/uk/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/zh_CN/LC_MESSAGES/lyx.mo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/print/lyx/work/stage/usr/local/share/locale/zh_TW/LC_MESSAGES/lyx.mo:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/print/lyx
Comment 1 Edward.Sanford.Sutton, III 2025-01-22 22:49:32 UTC
Created attachment 256922 [details]
Insert NLS variable on relevant pkg-plist lines. Git friendly version of previous patch

New patch content should be the same but redid it from base of tree using git format-patch to try to make things easier for committers.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-01-24 01:21:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e72fba3b54d7a64fd1aab869399fb349a32865a4

commit e72fba3b54d7a64fd1aab869399fb349a32865a4
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2025-01-24 01:18:34 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2025-01-24 01:20:39 +0000

    print/lyx: Update to 2.4.3

    Fix plist when build with OPTIONS_UNSET+=NLS [1]

    PR:             284274 [1]
    Reported by:    mirror176@hotmail.com [1]

 print/lyx/Makefile  |  4 +---
 print/lyx/distinfo  |  6 +++---
 print/lyx/pkg-plist | 54 ++++++++++++++++++++++++++---------------------------
 3 files changed, 31 insertions(+), 33 deletions(-)