Created attachment 256921 [details] Patches update: Remove include_Makefile.am and rename+update configure to configure.ac Build fails to apply patches: configure is now configure.am. include_Makefile.am patch no longer seems appropriate. This was only tested for fixing the build and run testing is not yet performed. A possible issue for upstream is it looks like configure.am has version at 0.7.7 but I don't know yet if that impacts a final build.
Thank you for mentioning this. These changes were already in my original patch [0], but weren't included in commit [1] for some reason. I'm rather shy person to argue with people (especially, the elders), so we have now what we have. I may try to re-submit the remains, as they were planned, still it all will depend on who (if at all) will commit it. I'll try this tomorrow and see how it will go… [0] https://bugs.freebsd.org/bugzilla/attachment.cgi?id=255365&action=diff [1] https://cgit.freebsd.org/ports/commit/?id=98ec15bd966d6ff201e97c433109d328e8457dbb
P.S. Every time when receiving such comments as [0] I re-think, whether my volunteering for FreeBSD project worth my time/effort just to meet some expectations of some people about my work. Yes, not all people here are like this one, but no one seems to care enough to do something with this to keep the environment for contributors more pleasant and not stressful. Seems, elders just usually think what they do is always good enough, and what we, the newcomers do is never good enough… Actually, I may be not really welcome here, at least this is how I feel about it. So, I'm not sure, whether I would be able to maintain the ports I do now in long run: it may be just not sustainable life for me, emotion-wise. If you are really interested in the port, I may transfer it to you, if you like… [0] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284245#c1
I assume it was just human error for them to have been left out as the port will fail to build since it has patches that cannot apply to extracted files until the patches are updated. As I didn't know if it is better to continue here or continue on the old PR where your patch covered it first and better so I sent an email to the committer. Shortly thereafter I remembered that hotmail is known to drop some of my emails and it should have been a last resort instead of first step for me to reach 'anyone'; I even forgot to copy myself in on my own email which often shows the messages fail to deliver so now I don't know where it stands until I get a reply or not. As a result, I'd say feel free to reach out to the committer (they would already be familiar with their own work), or let it flow through with whoever will take up the commit work if you think that would be better. I've been a maintainer once for a little while years ago but with how slow I am to respond and difficulties I seem to have with basic porting efforts I normally don't seek that out. I've had a few ports I made privately over the years I never felt were up to the quality of ports tree entries. If my first comment was off-putting somehow I apologize. I just tried to start diagnosing several build failures today that my system has had while trying to provide information of what I thought was going wrong on my side and include a fix for my side where possible. I tried to keep the PR on topic and to the point instead of as casual conversation. I appreciate the work of both maintainers and committers. You are in that list and the appreciation isn't undone by someday releasing maintainership. Thank you for your contributions.
Thank you for your kind words: this is what really helped me. I'll try to make new ports and maintain existing ones not for reviewers, but for people like you, thankful for my humble efforts. I like to think my work is really needed by many people, not just those who say this explicitly. I could be doing this even not being thanked at all, just if not being mistreated. Every time I submit a patch I pray Greta Thunberg Herself (glorify Her name) for it either been reviewed/commented by friendly and helpful person or rather not reviewed at all!! I'll try to do what I could to fix this, and hope it will help.
Done. Let's wait and hope for the best. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282898#c12
(In reply to Älven from comment #5) Attach all patches to this PR and I'll commit.
Created attachment 257052 [details] [MISSED][PATCH] comms/aldo: update 0.7.7 → 0.7.8
(In reply to Vladimir Druzenko from comment #6) Thanks, here it is.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=96e7c8e5fba1b061b7942fbcfb3d22d52263b5a1 commit 96e7c8e5fba1b061b7942fbcfb3d22d52263b5a1 Author: Älven <alster@vinterdalen.se> AuthorDate: 2025-01-27 20:28:34 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-01-27 20:28:34 +0000 comms/aldo: Add missed patches during update 0.7.7 → 0.7.8 PR: 284281 282898 Fixes: 98ec15bd966d (Updated to new version and changed Maintainer) comms/aldo/Makefile | 1 - comms/aldo/files/patch-VERSION (new) | 6 ++++ comms/aldo/files/patch-configure (gone) | 12 -------- comms/aldo/files/patch-configure.ac (new) | 36 +++++++++++++++++++++++ comms/aldo/files/patch-include_Makefile.in (gone) | 11 ------- 5 files changed, 42 insertions(+), 24 deletions(-)
Thanks.
(In reply to Älven from comment #2) I'm very glad that you make so many patches with port updates and improvements. We need more maintainers and committers like you!
P.S. If your updates don't get committed for a long time, add me to the CC and I'll try to do it.
(In reply to Vladimir Druzenko from comment #11) > I'm very glad that you make so many patches with port updates and improvements. > We need more maintainers and committers like you! Really?? :) I'm happy to hear this!! :) Never expected near anything like this! :) It's the first time I was welcomed like this. I well remember these words for long, and it will help me in the future to continue my humble work for FreeBSD, knowing for sure there are people who really welcomes me here! I'll know I'm not alone. (In reply to Vladimir Druzenko from comment #12) > P.S. If your updates don't get committed for a long time, add me to the CC and I'll try to do it. You was always trying to help me, even without asking unneeded questions. While I always glad been offered help in general, your help was always reassuring me, that every time you assigned yourself to my PRs, they would likely to go well. Thank you once again!
(In reply to Älven from comment #13) We can continue our conversation on discord (https://discord.com/invite/freebsd) or IRC (#freebsd @ Libera.Chat). My nick is VVD.