Bug 284293 - multimedia/clapper: Adopt and Update to 0.8.0
Summary: multimedia/clapper: Adopt and Update to 0.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-23 14:41 UTC by Yusuf Yaman
Modified: 2025-02-03 18:17 UTC (History)
3 users (show)

See Also:


Attachments
multimedia/clapper.patch: Update to 0.8.0 (40.96 KB, patch)
2025-01-23 14:44 UTC, Yusuf Yaman
no flags Details | Diff
multimedia/clapper.patch (42.07 KB, patch)
2025-01-31 17:53 UTC, Yusuf Yaman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman 2025-01-23 14:41:30 UTC

    
Comment 1 Yusuf Yaman 2025-01-23 14:44:34 UTC
Created attachment 256934 [details]
multimedia/clapper.patch: Update to 0.8.0

* Pet port{clippy,fmt,lint}
* Submitter becomes maintainer

ChangeLogs:
https://github.com/Rafostar/clapper/releases/tag/0.6.0
https://github.com/Rafostar/clapper/releases/tag/0.6.1
https://github.com/Rafostar/clapper/releases/tag/0.8.0

Thanks in advance.
Comment 2 Yusuf Yaman 2025-01-23 14:46:34 UTC
Unfortunately, I couldn't test it in poudriere but it builds fine on my 14.2-R/latest system.
Comment 3 Olivier Duchateau 2025-01-27 17:55:57 UTC
Please, could you add this patch [1] in order to have .desktop file.

Tested with the new Peas 2 API.

[1] https://codeberg.org/olivierd/freebsd-ports-wip/raw/branch/master/multimedia/clapper/files/patch-src_bin_clapper-app_data_meson.build
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2025-01-29 11:20:30 UTC
(In reply to Olivier Duchateau from comment #3)
I'll do it.

Thanks!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2025-01-30 16:29:16 UTC
Hi Yusuf,

I get this when building cleanly in poudriere:

Configuring config.h using configuration
Configuring clapper-gst-visibility.h using configuration
Run-time dependency gstreamer-gl-1.0 found: YES 1.24.11
Message: GStreamer OpenGL window systems: egl wayland x11
Message: GStreamer OpenGL platforms: egl glx
Message: GStreamer OpenGL apis: gles2 gl
Run-time dependency gstreamer-gl-prototypes-1.0 found: YES 1.24.11
Run-time dependency gstreamer-gl-x11-1.0 found: YES 1.24.11
Run-time dependency gstreamer-gl-wayland-1.0 found: YES 1.24.11
Run-time dependency gstreamer-gl-egl-1.0 found: YES 1.24.11
Run-time dependency gtk4-x11 found: YES 4.16.12
Run-time dependency gtk4-wayland found: YES 4.16.12

src/lib/clapper/meson.build:48:2: ERROR: Problem encountered: enhancers-loader option was enabled, but required dependencies were not found

A full log can be found at /wrkdirs/usr/ports/multimedia/clapper/work/clapper-0.8.0/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
===>  Script "configure" failed unexpectedly.
Please report the problem to nxjoseph@protonmail.com [maintainer] and attach
the
"/wrkdirs/usr/ports/multimedia/clapper/work/clapper-0.8.0/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Would you have a look at it?
Comment 6 Olivier Duchateau 2025-01-30 16:41:17 UTC
Build log is not complete, but you need the new Peas 2 API [1] (not available in ports collection, and an update of lang/gjs).

I think you should disable this feature.

[1] https://codeberg.org/olivierd/freebsd-gnome/src/branch/main/devel/libpeas2
Comment 7 Yusuf Yaman 2025-01-31 15:23:20 UTC
Sorry for the delay, in the meantime i was trying to set up my FreeBSD desktop from start with my own poudriere repo, I think now i will be able to test my ports with poudriere without needing to try to fetch binary packages while building the port in poudriere.

(In reply to Olivier Duchateau from comment #3)
Oh, I didn't know that patch but I am alreadying installing the .desktop file in post-patch section, do i need to do that? Also, I don't know about libpeas v2, how did you get it? I think i need to disable "enhancers-loader" feature which depend on libpeas v2 until it comes to ports tree.

(In reply to Fernando Apesteguía from comment #5)
I'll try to address this issue as my desktop is ready now to work with poudriere.

(In reply to Olivier Duchateau from comment #6)
Does clapper depend on lang/gjs anymore? I don't think so.

Thanks all!
Comment 8 Yusuf Yaman 2025-01-31 17:53:24 UTC
Created attachment 257146 [details]
multimedia/clapper.patch

It should be fine now, it passes poudriere tests on 14.2-R/latest.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2025-01-31 19:19:58 UTC
(In reply to Yusuf Yaman from comment #8)
Look for PACKAGE_FETCH_* variables in poudriere.conf. It can download binary packages if available so you don't have to rebuild the depenedencies.
Comment 10 Yusuf Yaman 2025-01-31 21:08:14 UTC
(In reply to Fernando Apesteguía from comment #9)
Thanks but it did not work for me most of the time. I think it's better to only use ports instead of fetching binary packages. At least, I can test my ports with poudriere because i won't have to mess with binary packages because it mostly did not work for me as expected.
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2025-02-03 17:54:04 UTC
Committed,

Thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2025-02-03 17:54:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=05cb8386d2c1a0ea4dee65593a15522f3677fdca

commit 05cb8386d2c1a0ea4dee65593a15522f3677fdca
Author:     usuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2025-01-31 19:35:13 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2025-02-03 17:53:30 +0000

    multimedia/clapper: add additional patch

    ChangeLogs:
    https://github.com/Rafostar/clapper/releases/tag/0.6.0
    https://github.com/Rafostar/clapper/releases/tag/0.6.1
    https://github.com/Rafostar/clapper/releases/tag/0.8.0

    Submitter becomes maintainer. Already maintainer of other ports.

    PR:     284293

 multimedia/clapper/Makefile                        |  57 +-
 multimedia/clapper/distinfo                        |   6 +-
 ...rc_lib_clapper_features_mpris_meson.build (new) |  11 +
 ...per_features_server_clapper-server-mdns.c (new) |  11 +
 multimedia/clapper/pkg-plist                       | 704 +++++++++++++++++++--
 5 files changed, 706 insertions(+), 83 deletions(-)
Comment 13 Yusuf Yaman 2025-02-03 18:17:51 UTC
You are welcome and thanks for reviewing.