Bug 284494 - net/self-service-password: update to 1.7.2
Summary: net/self-service-password: update to 1.7.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/ltb-project/self-s...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-31 19:50 UTC by Krzysztof
Modified: 2025-02-09 15:38 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+
ports: merge-quarterly?


Attachments
update patch (100.06 KB, patch)
2025-01-31 19:50 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff
poudriere testport log (38.13 KB, text/plain)
2025-01-31 19:50 UTC, Krzysztof
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2025-01-31 19:50:10 UTC
Created attachment 257149 [details]
update patch

There is new version of net/self-service-password. I've made a patch. It was tested with poudriere - a testport logfile is attached
Comment 1 Krzysztof 2025-01-31 19:50:36 UTC
Created attachment 257150 [details]
poudriere testport log
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-08 12:50:34 UTC
Hello,

Is there a reason for '+=' in:
SUB_LIST+= and PLIST_SUB+= since this vars are being defined here, i.e., outside an if condition that might change an existing var?

My tests shows that pkg-message is ok with:

```diff
-SUB_LIST+=     PKGNAME=${PKGNAME}
+SUB_LIST=      PKGNAME=${PKGNAME}

-PLIST_SUB+=    SSP_GRP=${WWWGRP} \
+PLIST_SUB=     SSP_GRP=${WWWGRP} \
                SSP_OWN=${WWWOWN}
```

Cheers
Comment 3 Krzysztof 2025-02-09 09:40:46 UTC
I'm still learning ports framework :-)))

I think that was my mistake. Propably I've made a Makefile looking at another one.  So it is good idea to change these declarations of variables.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-02-09 15:31:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fef30a5455c1b73a6de60cd6330fa39b2cc87853

commit fef30a5455c1b73a6de60cd6330fa39b2cc87853
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2025-02-09 15:29:22 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2025-02-09 15:30:44 +0000

    net/self-service-password: Update to 1.7.2

    ChangeLog:
    https://github.com/ltb-project/self-service-password/releases/tag/v1.7.2

    PR:             284494

 net/self-service-password/Makefile  |    6 +-
 net/self-service-password/distinfo  |    6 +-
 net/self-service-password/pkg-plist | 1530 +++++++++++++++++++++++++++--------
 3 files changed, 1215 insertions(+), 327 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-09 15:38:20 UTC
(In reply to Krzysztof from comment #3)

Committed with minor fixes, thanks!