Created attachment 257184 [details] patch to update to 7.3.6.10201 Update to google-earth-pro 7.3.6.10201 from build 10155.
Hello John, portlint -C: WARN: astro/google-earth-pro/pkg-plist: [140]: installing shared libraries, please define USE_LDCONFIG as appropriate WARN: Makefile: [43]: possible use of "${CHMOD}" found. Use @(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead. Could you take a look if reccomended portlint warnings are valid? Cheers
(In reply to Nuno Teixeira from comment #1) It's a linux package, some warnings will be always produced by portlint :)
(In reply to Dima Panov from comment #2) Even for a linux port aren't this warnings fixable as port installs shared libraries [1] and uses $CHMOD instead of recommended operators in pkg-plist instead [2]? [1] > WARN: astro/google-earth-pro/pkg-plist: [140]: installing shared libraries, > please define USE_LDCONFIG as appropriate Should or shouldn't USE_LDCONFIG be used? https://docs.freebsd.org/en/books/porters-handbook/book/#porting-shlibs [2] > WARN: Makefile: [43]: possible use of "${CHMOD}" found. Use > @(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead. ${CHMOD} +x ${STAGEDIR}${LINUXBASE}/opt/google/earth/pro/googleearth-bin versus https://docs.freebsd.org/en/books/porters-handbook/book/#plist-keywords-base-empty
Created attachment 257197 [details] Move CHMOD to pkg-plist to quiet portlint My read of USE_LDCONFIG is that it is for when a port/pkg installs shared libraries in the normal directories, so that other programs will find them when run after the pkg was installed. In this case the shared libraries are for google-earth-pro's own use and it use a start up script to set everything needed before running the executable. So I do not think it makes sense to add USE_LDCONFIG.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1cb81d4979aaf6a4165ac0dc38c326905a559ed4 commit 1cb81d4979aaf6a4165ac0dc38c326905a559ed4 Author: John Hay <jhay@FreeBSD.org> AuthorDate: 2025-02-03 17:38:56 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2025-02-03 17:40:12 +0000 astro/google-earth-pro: Update to 7.3.6.10201 - Move CHMOD to pkg-plist to quiet portlint PR: 284521 astro/google-earth-pro/Makefile | 3 +-- astro/google-earth-pro/distinfo | 6 +++--- astro/google-earth-pro/pkg-plist | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-)
(In reply to John Hay from comment #4) Thanks for explanation.
Committed, thanks!