Bug 284558 - ports-mgmt/porttools: Remove incorrect and unnecessary GH_TAGNAME
Summary: ports-mgmt/porttools: Remove incorrect and unnecessary GH_TAGNAME
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-04 09:46 UTC by Yasuhiro Kimura
Modified: 2025-02-19 05:51 UTC (History)
1 user (show)

See Also:
yasu: maintainer-feedback-

Attachments
Patch file (2.50 KB, patch)
2025-02-04 09:46 UTC, Yasuhiro Kimura 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2025-02-04 09:46:26 UTC 
Created attachment 257217 [details]
Patch file

Current value of GH_TAGNAME corresponds to not 1.11 but 1.10. And defult value of GH_TAGNAME is "1.11" in this case. So just remove it to get correct distfile.

While here,
* Switch to DISTVERSION.
* Pet portlint.
* Tidy up Makefile with portfmt.
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2025-02-19 05:38:05 UTC 
Maintainer timeout. Take.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-02-19 05:48:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=19d0e890093ffb39b991fcbf9430c689daefc90e

commit 19d0e890093ffb39b991fcbf9430c689daefc90e
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2025-02-04 09:27:15 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2025-02-19 05:45:40 +0000

    ports-mgmt/porttools: Fix content of distfile

    When this port was update to 1.11, value of GH_TAGNAME wasn't
    changed.and still points to the commit that is referenced by "1.10"
    tag. As a result name of distfile was changed but content was kept
    same as that of 1.10. Since defult value of GH_TAGNAME is "1.11" in
    this case, fix content of distfile by just removing GH_TAGNAME.

    While here,
    * Switch to DISTVERSION.
    * Pet portlint.
    * Tidy up Makefile with portfmt.

    PR:             284558
    Approved by:    maintiner timeout
    Fixes:          2377892144ca ports-mgmt/porttools: update to 1.11

 ports-mgmt/porttools/Makefile | 20 +++++++++++---------
 ports-mgmt/porttools/distinfo |  6 +++---
 2 files changed, 14 insertions(+), 12 deletions(-)