Bug 284581 - textproc/apache-commons-csv: Update to 1.13.0
Summary: textproc/apache-commons-csv: Update to 1.13.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://commons.apache.org/proper/com...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-05 01:44 UTC by Mitchell Clay
Modified: 2025-02-11 10:17 UTC (History)
1 user (show)

See Also:

Attachments
update patch (1.30 KB, patch)
2025-02-05 01:44 UTC, Mitchell Clay 		mclay: maintainer-approval+
Details | Diff
revised update patch (2.28 KB, patch)
2025-02-11 00:37 UTC, Mitchell Clay 		mclay: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mitchell Clay 2025-02-05 01:44:09 UTC 
Created attachment 257246 [details]
update patch
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-10 17:54:08 UTC 
BUILD_DEPENDS=  ${JAR_DEPENDS}
RUN_DEPENDS=    ${JAR_DEPENDS}

Where is JAR_DEPENDS defined?

Also there are several warnings from portclippy.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-10 17:58:31 UTC 
Build fine with Makefile:
PORTNAME=       commons-csv
DISTVERSION=    1.13.0
CATEGORIES=     textproc java devel
MASTER_SITES=   APACHE_COMMONS_BINARIES
PKGNAMEPREFIX=  apache-
DISTNAME=       ${PORTNAME}-${DISTVERSION}-bin

MAINTAINER=     mclay@astate.edu
COMMENT=        Java support for Comma Separated Value format
WWW=            https://commons.apache.org/proper/commons-csv/

LICENSE=        APACHE20

USES=           java

NO_ARCH=        yes
NO_BUILD=       yes

WRKSRC=         ${WRKDIR}/${PORTNAME}-${DISTVERSION}

JARFILE=        ${PORTNAME}.jar
PLIST_FILES=    ${JAVAJARDIR}/${JARFILE}
PORTDOCS=       *
OTHERDOCS=      LICENSE.txt NOTICE.txt RELEASE-NOTES.txt

OPTIONS_DEFINE= DOCS

do-install:
        @${ECHO_MSG} -n ">> Installing JAR as ${JAVAJARDIR}/${JARFILE}..."
        ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.jar ${STAGEDIR}${JAVAJARDIR}/${JARFILE}
        @${ECHO_MSG} " [ DONE ]"

do-install-DOCS-on:
        @${ECHO_MSG} -n ">> Installing documentation in ${DOCSDIR}..."
        @cd ${WRKSRC}/apidocs \
          && ${FIND} . -type d -exec ${MKDIR} ${STAGEDIR}${DOCSDIR}/{} \; \
          && ${FIND} . -type f -exec ${INSTALL_DATA} {} ${STAGEDIR}${DOCSDIR}/{} \;
        ${INSTALL_DATA} ${OTHERDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}/
        @${ECHO_MSG} " [ DONE ]"

.include <bsd.port.mk>
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-10 17:59:55 UTC 
(In reply to Vladimir Druzenko from comment #2)
Also:
:%s/PORTVERSION/DISTVERSION/g
Comment 4 Mitchell Clay 2025-02-11 00:37:21 UTC 
Created attachment 257397 [details]
revised update patch

this should fix all of issues mentioned
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-02-11 10:17:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c73a0f3f26a366a27bffdbe6c75dc45628ca185b

commit c73a0f3f26a366a27bffdbe6c75dc45628ca185b
Author:     Mitchell Clay <mclay@astate.edu>
AuthorDate: 2025-02-11 10:07:39 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-02-11 10:15:00 +0000

    textproc/apache-commons-csv: Update 1.11.0 => 1.13.0

    Changelogs:
    https://commons.apache.org/proper/commons-csv/changes.html#a1.13.0

    Improve port:
    - remove unnecessary lines,
    - replace PORTVERSION with DISTVERSION,
    - pet portclippy.

    PR:     284581

 textproc/apache-commons-csv/Makefile | 16 +++++++---------
 textproc/apache-commons-csv/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 12 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-11 10:17:27 UTC 
Thanks.