Bug 284650 - lang/squirrel: update to 3.2 and take maintainership
Summary: lang/squirrel: update to 3.2 and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: http://squirrel-lang.org/#devstate
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-08 00:12 UTC by Mitchell Clay
Modified: 2025-02-09 12:30 UTC (History)
1 user (show)

See Also:

Attachments
update patch (60.17 KB, patch)
2025-02-08 00:12 UTC, Mitchell Clay 		no flags Details | Diff
poudriere log (43.14 KB, text/plain)
2025-02-08 00:14 UTC, Mitchell Clay 		no flags Details
Patch for squirrel (60.00 KB, patch)
2025-02-08 14:40 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mitchell Clay 2025-02-08 00:12:58 UTC 
Created attachment 257320 [details]
update patch
Comment 1 Mitchell Clay 2025-02-08 00:14:32 UTC 
Created attachment 257321 [details]
poudriere log
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2025-02-08 14:40:58 UTC 
Created attachment 257326 [details]
Patch for squirrel

Hi,

Some improvements to your patch:
* Add LICENSE_FILE
* Use TAB for spacing
* Report correct version in .cmake files
* Disable static binary and libs
* Adjust port Makefile layout to more closely follow Porters Handbook
* Disable GNU C/C++ extensions

Does this look ok to you?

Thanks for working on this!
Comment 3 Mitchell Clay 2025-02-08 16:59:11 UTC 
Yes, thanks for the help!
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-02-09 12:23:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=707bf5e07d22f544a1a14c96cd4be7776fafe0de

commit 707bf5e07d22f544a1a14c96cd4be7776fafe0de
Author:     Mitchell Clay <mclay@astate.edu>
AuthorDate: 2025-02-09 08:21:48 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2025-02-09 12:19:30 +0000

    lang/squirrel: Update to 3.2 and take maintainership

    * Add LICENSE_FILE
    * Report correct version in .cmake files
    * Disable static binary and libs
    * Adjust port Makefile layout to more closely follow Porters Handbook
    * Disable GNU C/C++ extensions

    References:
    https://github.com/albertodemichelis/squirrel/commit/af69eb70844d5830c99d24e671352b2e5e0fe255

    PR:             284650

 lang/squirrel/Makefile                      |   23 +-
 lang/squirrel/distinfo                      |    6 +-
 lang/squirrel/files/patch-CMakeLists.txt    |   28 +-
 lang/squirrel/files/patch-git_57ca6c (gone) | 1291 ---------------------------
 lang/squirrel/pkg-plist                     |    7 +-
 5 files changed, 29 insertions(+), 1326 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2025-02-09 12:30:45 UTC 
Committed, thanks!