Bug 284759 - net-mgmt/netdata: Update to v2.2.5
Summary: net-mgmt/netdata: Update to v2.2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-12 17:14 UTC by Namkhai B.
Modified: 2025-02-21 00:31 UTC (History)
3 users (show)

See Also:
vvd: maintainer-feedback+

Attachments
net-mgmt/netdata: Update to v2.2.5 (21.71 KB, patch)
2025-02-12 17:14 UTC, Namkhai B. 		no flags Details | Diff
net-mgmt/netdata: Update to v2.2.5 (22.12 KB, patch)
2025-02-13 16:03 UTC, Namkhai B. 		vvd: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Namkhai B. 2025-02-12 17:14:58 UTC 
Created attachment 257438 [details]
net-mgmt/netdata: Update to v2.2.5

Changelog: https://github.com/netdata/netdata/releases/tag/v2.2.4
https://github.com/netdata/netdata/releases/tag/v2.2.5

* Add newsyslog.conf.d configuration (see bug #281687)
* Fixed CLOUD_DASHBOARD distfile
* Updated CLOUD_DASHBOARD to 20250212
* Updated pkg-message
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2025-02-13 00:33:38 UTC 
${INSTALL_DATA} ${FILESDIR}/netdata.newsyslog.conf.sample ${STAGEDIR}${PREFIX}/etc/netdata.conf.sample

should probably say

${INSTALL_DATA} ${FILESDIR}/netdata.newsyslog.conf.sample ${STAGEDIR}${ETCDIR}/netdata.newsyslog.conf.sample

?
Comment 2 Namkhai B. 2025-02-13 16:03:15 UTC 
Created attachment 257478 [details]
net-mgmt/netdata: Update to v2.2.5

Hmm yes, good catch. I just took that line from nncp. It's probably better to have the sample file in %%ETCDIR%% tho, moved it there.
Comment 3 Namkhai B. 2025-02-13 16:04:10 UTC 
BTW bug #273831 and #267825 can probably be closed too.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-14 13:48:12 UTC 
(In reply to Daniel Engberg from comment #1)
Maybe better:
${INSTALL_DATA} ${FILESDIR}/netdata.newsyslog.conf.sample ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/netdata.conf.sample
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2025-02-15 12:49:09 UTC 
(In reply to Vladimir Druzenko from comment #4)
https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.port.mk#L1548
No need to change
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2025-02-15 13:07:39 UTC 
(In reply to Daniel Engberg from comment #5)
I know what is ETCDIR.
I suggested to use etc/newsyslog.conf.d/ for netdata.newsyslog.conf.sample.
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-02-21 00:28:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a6b67ce13a845a15af98a89d9fd9708aa29cfc0

commit 2a6b67ce13a845a15af98a89d9fd9708aa29cfc0
Author:     Namkhai Bourquin <nk@nkeor.me>
AuthorDate: 2025-02-20 23:59:30 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2025-02-20 23:59:35 +0000

    net-mgmt/netdata: Update to 2.2.5

    Changelog:
    https://github.com/netdata/netdata/releases/tag/v2.2.4
    https://github.com/netdata/netdata/releases/tag/v2.2.5

    * Add newsyslog.conf.d configuration (PR 281687)
    * Fixed CLOUD_DASHBOARD distfile
    * Updated CLOUD_DASHBOARD to 20250212
    * Updated pkg-message

    PR:             284759

 net-mgmt/netdata/Makefile                          |   6 +-
 net-mgmt/netdata/distinfo                          |  10 +-
 .../files/netdata.newsyslog.conf.sample (new)      |   9 +
 net-mgmt/netdata/pkg-message                       |   4 +-
 net-mgmt/netdata/pkg-plist                         | 210 +++++++++++----------
 5 files changed, 126 insertions(+), 113 deletions(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2025-02-21 00:31:54 UTC 
Committed, thanks!