Bug 284825 - net/dico: update to 2.12
Summary: net/dico: update to 2.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-14 20:48 UTC by info
Modified: 2025-02-20 23:33 UTC (History)
1 user (show)

See Also:


Attachments
update to version 2.12 (958 bytes, patch)
2025-02-14 20:48 UTC, info
no flags Details | Diff
update to version 2.12 (993 bytes, patch)
2025-02-16 19:06 UTC, info
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description info 2025-02-14 20:48:20 UTC
Created attachment 257541 [details]
update to version 2.12

- update to version 2.12
- upgrade dependency pcre to pcre2
release info: https://savannah.gnu.org/news/?id=10708
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2025-02-15 00:17:38 UTC
The build fails in phase lib-depends:

===>   dico-2.12 depends on shared library: libpcre.so - not found
===>   Installing existing package /packages/All/pcre2-10.45.pkg
[13Ri386-main-job-04] Installing pcre2-10.45...
[13Ri386-main-job-04] Extracting pcre2-10.45: .......... done
===>   dico-2.12 depends on shared library: libpcre.so - not found
*** Error code 1

Stop.
make: stopped in /usr/ports/net/dico

This is because package pcre2 does not actually install a libpcre.so.  Please check and resubmit.  I also recommend telling the port that it must use pcre2, not pcre in case both are installed.
Comment 2 info 2025-02-16 19:06:11 UTC
Created attachment 257590 [details]
update to version 2.12

updated patch
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2025-02-16 19:16:43 UTC
Thanks.

Please try to submit future patches as git commits against the ports tree repository.  Use git-format-patch(1) to create the patch.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2025-02-16 20:47:33 UTC
Now there are plist issues:

====> Running Q/A tests (stage-qa)
Warning: you might not need LIB_DEPENDS on libreadline.so.8
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: include/dico/conv.h
Error: Orphaned: lib/dico/greek_kbd.a
Error: Orphaned: lib/dico/greek_kbd.so
Error: Orphaned: share/locale/ro/LC_MESSAGES/dico.mo
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.

Please fix this issue, then test the port (ideally with Poudriere) and resubmit.

This is the third time in quick successions your ports have issues that are very easy to discover with testing.  Please save both of us some time and test your patches before you submit them.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-18 13:53:45 UTC
No response to the plist issues.
Will postpone this update to my next batch pending response.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-02-20 23:29:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f54ee717f03c170457412ede03764c89047a7ee7

commit f54ee717f03c170457412ede03764c89047a7ee7
Author:     FreeBSD <info@dikt.tv>
AuthorDate: 2025-02-14 22:40:31 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-02-20 23:27:21 +0000

    net/dico: update to 2.12

     - update to version 2.12
     - upgrade dependency pcre to pcre2
     - add missing dependencies
     - add TK option to install the gcider binary

    release info: https://savannah.gnu.org/news/?id=10708

    PR:             284825
    Co-authored-by: fuz@FreeBSD.org

 net/dico/Makefile  | 13 +++++++------
 net/dico/distinfo  |  6 +++---
 net/dico/pkg-plist |  5 +++++
 3 files changed, 15 insertions(+), 9 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2025-02-20 23:33:29 UTC
Thank you for your contribution.

I found some additional issues with the port that I fixed.
Please carefully read the release notes on updates and make sure to adjust dependencies and options when upstream adds features to the port.