Bug 284880 - devel/boost-libs: 1.87.0 fails to build on armv7
Summary: devel/boost-libs: 1.87.0 fails to build on armv7
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-18 15:26 UTC by Brad Davis
Modified: 2025-02-21 16:04 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (office)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2025-02-18 15:26:14 UTC
Looks like there is a bug building on armv7 that is fixed upstream already


<inline asm>:2:41: error: expected '%<type>' or "<type>"
    2 | .pushsection ".debug_gdb_scripts", "MS",@progbits,1
      |                                         ^

Upstream discussion is here:

https://github.com/boostorg/unordered/issues/294


The commits that fix it are here:

https://github.com/boostorg/interprocess/pull/246
and
https://github.com/boostorg/unordered/pull/295

or possibly there is an option to disable the embedded gdb scripts.  I am not sure which is the best path.
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-02-20 08:37:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1617413bd596f3086dbe227c5205303f3c632782

commit 1617413bd596f3086dbe227c5205303f3c632782
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2025-02-20 08:31:49 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2025-02-20 08:36:24 +0000

    devel/boost-libs: unbreak build on armv7 (+)

    @progbits is spelled %progbits on armv7

    Update armv7 patch with two more places to fix this.

    Based on https://github.com/boostorg/interprocess/pull/246/
    and https://github.com/boostorg/unordered/pull/295
    Issue was raised in https://github.com/boostorg/unordered/issues/294

    PR:     284880
    Sponsored by:   Future Crew, LLC

 devel/boost-libs/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2025-02-20 13:00:41 UTC
My local patch I had planned to commit to address this also has
${WRKSRC}/boost/json/detail/gdb_printers.hpp as a file with the
progbits replacement.  Is this needed, too?
Have you build-tested your patch on armv7?
Comment 3 R. Christian McDonald freebsd_committer freebsd_triage 2025-02-20 18:18:56 UTC
(In reply to Robert Clausecker from comment #2)
Yes it is needed too 

Ref: https://github.com/boostorg/json/commit/57d42f07158b8ea4a713378c90d22b28ca4787f8
Comment 4 Dima Panov freebsd_committer freebsd_triage 2025-02-20 19:07:49 UTC
(In reply to Robert Clausecker from comment #2)
Yeah, I found it too and will commit asap

Sorry, cannot confirm build, I have only aarch64/amd64 hardware :(
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-20 19:19:00 UTC
(In reply to Dima Panov from comment #4)

You can run armv7 jails on aarch64 hosts.  This works e.g. with a Raspberry Pi 4B or a Windows ARM Dev Kit, but not with a Mac.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-02-21 00:41:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7c991a3b4fa11bed3b2c4a3a8970593aa9c14a5

commit a7c991a3b4fa11bed3b2c4a3a8970593aa9c14a5
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2025-02-21 00:38:43 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2025-02-21 00:38:43 +0000

    devel/boost-libs: Boost.JSON library is also need to  be patched for @progbist on 32-bit ARM (+)

    See https://github.com/boostorg/json/commit/57d42f07158b8ea4a713378c90d22b28ca4787f8 for details

    PR:     284880
    Sponsored by:   Future Crew, LLC

 devel/boost-libs/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2025-02-21 16:04:47 UTC
Should be fine now.  This matches my own patch.