Bug 284955 - net/cloud-init: drop stale dependency upon boto
Summary: net/cloud-init: drop stale dependency upon boto
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL: https://reviews.freebsd.org/D48959
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-21 19:59 UTC by Ruslan Makhmatkhanov
Modified: 2025-02-22 15:36 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (andrey)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2025-02-21 19:59:12 UTC
boto is not used by cloud-init since v0.7.5 according to changelog:
https://github.com/canonical/cloud-init/blob/main/ChangeLog#L5002

it is not mentioned in requirements and isn't used in code anywhere. There is just some reference in doc/examples/seed/README. Since boto was deprecated upstream and our boto port was also expired, I'm going to remove that dependency from net/cloud-init and net/cloud-init-devel ports. Don't you mind?
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2025-02-21 19:59:35 UTC
Add @rene
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2025-02-21 20:54:08 UTC
See also https://reviews.freebsd.org/D48959 which proposes the same thing.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2025-02-21 20:54:41 UTC
The change is fine with me, I only noticed the (stale) dependency on boto.
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2025-02-21 21:36:43 UTC
(In reply to Rene Ladan from comment #2)

Wasn't aware of this. Great. Would you commit or should I do this?
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2025-02-22 14:27:47 UTC
(In reply to Ruslan Makhmatkhanov from comment #4)

Feel free to commit this since you already "own" this PR.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-02-22 15:35:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=579e7e5b6d19a19a29c74cdd8b98de79acd3cca6

commit 579e7e5b6d19a19a29c74cdd8b98de79acd3cca6
Author:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
AuthorDate: 2025-02-22 15:24:56 +0000
Commit:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
CommitDate: 2025-02-22 15:34:05 +0000

    net/cloud-init and net/cloud-init-devel: undeprecate

    - drop stale dependency on boto - it is not used since v0.7.5 [1]
    - remove DEPRECATED
    - bump PORTREVISION

    [1] https://github.com/canonical/cloud-init/blob/main/ChangeLog#L5002

    PR:             284955
    With hat:   python
    Reviewed by:    rene
    Differential Revision:  https://reviews.freebsd.org/D48959

 net/cloud-init-devel/Makefile | 8 ++------
 net/cloud-init/Makefile       | 8 ++------
 2 files changed, 4 insertions(+), 12 deletions(-)
Comment 7 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2025-02-22 15:36:50 UTC
Done, thanks!