Created attachment 257749 [details] Patch for libnvme * Use DISTVERSION (and consistent) https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github * Fix COMMENT * Define LICENSE_FILE https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license * Remove CXXFLAGS, project uses C * Simplify MAJORVER definition * Adjust pkg-descr * Rearrange Makefile so it follows Porters Handbook more close Poudriere testport OK 14.2-RELEASE and 13.4-RELEASE
Please leave the CXX flags. This project does use C++ for the tests. I have the tests disabled at the moment, but for ease of use, etc, please leave them here. Otherwise the changes look good and can proceed.
Another note, there's something wonky going on with upstream Meson build as it tried to run unit tests despite being disabled (make test).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3e5eab32850a99e051264ab160a0ee16c6f51abc commit 3e5eab32850a99e051264ab160a0ee16c6f51abc Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2025-02-23 16:02:14 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-02-23 16:11:02 +0000 devel/libnvme: Fix port * Use DISTVERSION (and consistent) * Fix COMMENT * Define LICENSE_FILE * Remove CXXFLAGS, project uses C * Simplify MAJORVER definition * Adjust pkg-descr * Rearrange Makefile so it follows Porters Handbook more closely Poudriere testport OK 14.2-RELEASE and 13.4-RELEASE PR: 284970 Reviewed by: imp devel/libnvme/Makefile | 26 ++++++++++++++++---------- devel/libnvme/pkg-descr | 2 +- devel/libnvme/pkg-plist | 4 ++-- 3 files changed, 19 insertions(+), 13 deletions(-)