Bug 285164 - multimedia/v4l_compat: Add include/linux/uvcvideo.h for webcam redirection support in net/freerdp3
Summary: multimedia/v4l_compat: Add include/linux/uvcvideo.h for webcam redirection su...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-04 21:30 UTC by Vladimir Druzenko
Modified: 2025-03-09 12:35 UTC (History)
3 users (show)

See Also:
makc: maintainer-feedback+


Attachments
Add include/linux/uvcvideo.h (942 bytes, patch)
2025-03-04 21:30 UTC, Vladimir Druzenko
vvd: maintainer-approval? (multimedia)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-04 21:30:26 UTC
Created attachment 258290 [details]
Add include/linux/uvcvideo.h

Required here:
https://github.com/FreeRDP/FreeRDP/blob/master/channels/rdpecam/client/v4l/uvc_h264.c#L28

net/freerdp3 build and work fine with this patch.

I can commit this patch self.
Comment 1 Max Brazhnikov freebsd_committer freebsd_triage 2025-03-05 20:48:39 UTC
Vladimir, have you tested other ports that depend on v4l_compat?
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-06 02:47:49 UTC
(In reply to Max Brazhnikov from comment #1)
$ grep v4l_compat INDEX-14 | wc -l
      85

Maybe 10 of them I rebuild already.
For example gecko-based: firefox, tor-browser, librewolf, waterfox, thunderbird.
Also ffmpeg, ffmpeg4, webcamd, mpv.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-07 10:26:06 UTC
(In reply to Max Brazhnikov from comment #1)
Are you offering exp-run?
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-08 20:47:52 UTC
There is new version of the FreeRDP 3.13.0 (https://github.com/FreeRDP/FreeRDP/releases/tag/3.13.0) and I want to commit it without current ugly patch.
Comment 5 Max Brazhnikov freebsd_committer freebsd_triage 2025-03-09 08:28:56 UTC
I don't think exp-run is need. The patch can be committed as is.
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-03-09 12:34:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=691e0cbdd4a9d11dba7db534304d52235ad5f78d

commit 691e0cbdd4a9d11dba7db534304d52235ad5f78d
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-03-09 12:00:42 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-09 12:32:20 +0000

    multimedia/v4l_compat: Add include/linux/uvcvideo.h for webcam support

    Used for webcam redirection support in net/freerdp3

    PR:             285164
    Approved by:    makc (multimedia, maintainer)

 multimedia/v4l_compat/Makefile  | 2 ++
 multimedia/v4l_compat/pkg-plist | 1 +
 2 files changed, 3 insertions(+)