Bug 285179 - www/opengist: enable arm64 builds by bundling arm64 and amd64 in node_modules
Summary: www/opengist: enable arm64 builds by bundling arm64 and amd64 in node_modules
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Santhosh Raju
URL: https://reviews.freebsd.org/D49246
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-05 14:42 UTC by Dave Cottlehuber
Modified: 2025-03-09 09:31 UTC (History)
0 users

See Also:
fox: maintainer-feedback+


Attachments
v1 patch (4.82 KB, patch)
2025-03-05 14:45 UTC, Dave Cottlehuber
no flags Details | Diff
stacked patch that adds support for dedicated opengist user (2.99 KB, patch)
2025-03-06 07:27 UTC, Dave Cottlehuber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2025-03-05 14:42:49 UTC

    
Comment 1 Dave Cottlehuber freebsd_committer freebsd_triage 2025-03-05 14:45:59 UTC
Created attachment 258312 [details]
v1 patch

My patch still has my LOCAL/dch as source, that should be changes once you
regenerate the patch files.

https://reviews.freebsd.org/D49246 or attachment as you prefer.

I applied portfmt/portclippy as well, feel free to ignore those changes ofc.

I'm still waiting on node to build for a final 14.2-RELEASE arm64 poudriere
to finish, but it builds cleanly from /usr/ports/www/opengist already.
Comment 2 Dave Cottlehuber freebsd_committer freebsd_triage 2025-03-05 15:04:55 UTC
poudriere ok on arm64 & amd64, 14.2-RELEASE
Comment 3 Dave Cottlehuber freebsd_committer freebsd_triage 2025-03-06 07:27:06 UTC
Created attachment 258343 [details]
stacked patch that adds support for dedicated opengist user

additional patch to add an opengist user by default, so this can run as non-root
Comment 4 Santhosh Raju freebsd_committer freebsd_triage 2025-03-07 08:05:16 UTC
Thank you Dave, this makes the package available to both amd64 and arm64, I was trying to get it done without much success.

I had a look at the patches and it looks fine. Just one question regarding the MASTER_SITES, in future if I bump the package version, should I switch it back to LOCAL/fox and upload the generated files in my account?

Otherwise you can commit the changes and I shall test out the package during the weekend.

Thank you once again for the clean up, adding arm64 support and testing the builds.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-03-09 00:58:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e4fb336cba5439a9f7f692df86c87a6dc1519f8

commit 0e4fb336cba5439a9f7f692df86c87a6dc1519f8
Author:     Dave Cottlehuber <dch@freebsd.org>
AuthorDate: 2025-03-09 00:45:26 +0000
Commit:     Santhosh Raju <fox@FreeBSD.org>
CommitDate: 2025-03-09 00:51:52 +0000

    www/opengist: Build fixes and improvements

    un-break arm64 by installing both esbuild arches
        - stop lang/go from fetching newer toolchains during build
        - pet port with portfmt & portclippy, fix pkg-plist

    run under non-root user by default
        - add UID, GID for opengist user
        - amend rc script to support user

    PR:             285179
    Reviewed by:    fox
    Sponsored by:   SkunkWerks, GmbH

 GIDs                           |  2 +-
 UIDs                           |  2 +-
 www/opengist/Makefile          | 45 ++++++++++++++++++++++++++++--------------
 www/opengist/distinfo          |  6 +++---
 www/opengist/files/opengist.in | 32 +++++++++++++++++++++++-------
 www/opengist/pkg-plist         |  7 +++----
 6 files changed, 63 insertions(+), 31 deletions(-)
Comment 6 Santhosh Raju freebsd_committer freebsd_triage 2025-03-09 09:31:11 UTC
Closing the ticket since patches have been applied to the package. Thank you again for the fixes and improvements.