Bug 285202 - dns/zns: make use of lang/go124 port
Summary: dns/zns: make use of lang/go124 port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-06 17:44 UTC by Yusuf Yaman
Modified: 2025-03-18 02:22 UTC (History)
4 users (show)

See Also:

Attachments
dns/zns.patch: make use of lang/go124 port (909 bytes, patch)
2025-03-06 17:46 UTC, Yusuf Yaman 		nxjoseph: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman 2025-03-06 17:44:58 UTC 

    


    


      



        
          Comment 1
        

        
          Yusuf Yaman

        

        
        

        
          2025-03-06 17:46:49 UTC
        

      






Created attachment 258359 [details]
dns/zns.patch: make use of lang/go124 port

Port works fine with lang/go124 and poudriere testport is OK on 142amd64-default.

Thanks in advance.

    


    


      



        
          Comment 2
        

        
          Koichiro Iwao

        

        
            freebsd_committer
            freebsd_triage
        

        
          2025-03-17 08:59:58 UTC
        

      






Is there any reason to switch Go version?

    


    


      



        
          Comment 3
        

        
          Yusuf Yaman

        

        
        

        
          2025-03-17 12:13:14 UTC
        

      






(In reply to Koichiro Iwao from comment #2)
Yes, it's because zns is using go 1.24 and port downloads go 1.24 in build procedure, lang/go124 became present after this port has been created.

    


    


      



        
          Comment 4
        

        
          Nuno Teixeira

        

        
            freebsd_committer
            freebsd_triage
        

        
          2025-03-17 23:44:27 UTC
        

      






===> Fetching all distfiles required by zns-0.3.0_1 for building
===> Fetching github.com/znscli/zns dependencies
go: downloading go1.24.0 (freebsd/amd64)

and

https://github.com/znscli/zns/blob/v0.3.0/go.mod shows 1.24.

    


    


      



        
          Comment 5
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2025-03-18 00:15:17 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb762a17c1ef78c39eb16e4729aa6fc3b7e8c7bf

commit fb762a17c1ef78c39eb16e4729aa6fc3b7e8c7bf
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2025-03-18 00:11:00 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2025-03-18 00:13:42 +0000

    dns/zns: Switch build to go124

    Use correct go version as shown in go.mod.

    PR:             285202

 dns/zns/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

    


    


      



        
          Comment 6
        

        
          Nuno Teixeira

        

        
            freebsd_committer
            freebsd_triage
        

        
          2025-03-18 00:17:13 UTC
        

      






Committed, thanks!

    


    


      



        
          Comment 7
        

        
          Koichiro Iwao

        

        
            freebsd_committer
            freebsd_triage
        

        
          2025-03-18 02:22:59 UTC
        

      






(In reply to Yusuf Yaman from comment #3)
That makes sense, thanks for the info.