Bug 285208 - audio/lollypop: update to version 1.4.41 (port with no maintainer)
Summary: audio/lollypop: update to version 1.4.41 (port with no maintainer)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://gitlab.gnome.org/World/lollypop
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-06 21:57 UTC by Zoltán Király
Modified: 2025-03-07 10:12 UTC (History)
1 user (show)

See Also:


Attachments
Patch that updates audio/lollypop to version 1.4.41 (2.59 KB, patch)
2025-03-06 21:57 UTC, Zoltán Király
no flags Details | Diff
Lollypop 1.4.41 running on FreeBSD 14.2 with Xfce 4.20 (144.56 KB, image/jpeg)
2025-03-06 22:00 UTC, Zoltán Király
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltán Király 2025-03-06 21:57:38 UTC
Created attachment 258368 [details]
Patch that updates audio/lollypop to version 1.4.41

This port currently has no maintainer, and I would prefer not to adopt it, as I don't think I will have the time to maintain it in the future. However, I'm submitting this patch to bring Lollypop to the latest version. I have tested the port by installing and using the program. I listened to music in it and didn't notice any issues, so it's working fine.

Changes I made to the Makefile:

- DISTVERSION: has been updated from 1.4.16 to 1.4.41.

- WWW: I replaced the address https://wiki.gnome.org/Apps/Lollypop as the site has been retired. The new address now points to the project's GitLab page: https://gitlab.com/lollypop-project/lollypop

- GL_TAGNAME and GL_TUPLE: I updated these to point to the hash of the latest release.

Lollypop changelog:

The project doesn't seem to have a changelog, but from the git commit history:

v1.4.11 :: bug fix release
https://gitlab.gnome.org/World/lollypop/-/commit/a0a51b85e9348f21ff88094e2cdecc5cf13bdc79

Previous versions (changes according to the git commit history):

v1.4.40
- Fix scrolling issue on mobile devices

v1.4.39
- Fix playlist export
- Fix suspend inhibitor

v1.4.38
- Fix startup notifications

v1.4.37
- Special PMOS release

Older releases than v1.4.37 don't seem to have a changelog.
Comment 1 Zoltán Király 2025-03-06 22:00:08 UTC
Created attachment 258369 [details]
Lollypop 1.4.41 running on FreeBSD 14.2 with Xfce 4.20
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-06 22:57:15 UTC
Don't need GL_TAGNAME - project have tag 1.4.41 and by default GL_TAGNAME=DISTVERSION.
Comment 3 Zoltán Király 2025-03-06 23:28:22 UTC
Thank you. Can you make this change, or should I re-upload the patch?
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-06 23:58:18 UTC
(In reply to Zoltán Király from comment #3)
Already done!
Testing build in poudriere now.
Comment 5 Zoltán Király 2025-03-07 00:01:47 UTC
Thank you. I wasn't able to test it in poudriere because I have a very old computer, and I couldn't compile Rust on it.

The method I used to compile it was installing Rust from the binary package and the rest of the dependencies from source. That's why I said I wouldn't want to take it under maintenance, it's too much for my computer and I don't think I'll have the time for it.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-07 01:26:03 UTC
I fixed this error too:
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/locale/bn/LC_MESSAGES/lollypop.mo
Error: Orphaned: share/locale/eu/LC_MESSAGES/lollypop.mo
Error: Orphaned: share/locale/gl/LC_MESSAGES/lollypop.mo
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

And this:
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:14:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
Comment 7 Zoltán Király 2025-03-07 01:29:19 UTC
Thank you. I appreciate your time.
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-03-07 09:52:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=907e7f6b1eacacbc7d427c5ff62f2143033376ad

commit 907e7f6b1eacacbc7d427c5ff62f2143033376ad
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-03-07 09:25:32 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-07 09:51:57 +0000

    audio/lollypop: Update 1.4.16 → 1.4.41, improve port

    Changelogs:
    https://gitlab.gnome.org/World/lollypop/-/releases

    Improve port:
     - WWW replace https://wiki.gnome.org/Apps/Lollypop with
       https://gitlab.com/lollypop-project/lollypop/ as the site has been
       "retired".
     - Sort items in USES, USE_GNOME, USE_GSTREAMER.
     - Add NO_ARCH - suggested by poudriere.
     - Pet portclippy.

    The patch is based on the patch form Zoltán Király
    <ports@zoltankiraly.com>.

    PR:             285208
    MFH:            2025Q1

 audio/lollypop/Makefile  | 19 +++++++++----------
 audio/lollypop/distinfo  | 10 +++++-----
 audio/lollypop/pkg-plist |  3 +++
 3 files changed, 17 insertions(+), 15 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-03-07 10:07:45 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5f31b919930ac533aac6e71361840c53fd5d0559

commit 5f31b919930ac533aac6e71361840c53fd5d0559
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-03-07 09:25:32 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-07 10:06:39 +0000

    audio/lollypop: Update 1.4.16 → 1.4.41, improve port

    Changelogs:
    https://gitlab.gnome.org/World/lollypop/-/releases

    Improve port:
     - WWW replace https://wiki.gnome.org/Apps/Lollypop with
       https://gitlab.com/lollypop-project/lollypop/ as the site has been
       "retired".
     - Sort items in USES, USE_GNOME, USE_GSTREAMER.
     - Add NO_ARCH - suggested by poudriere.
     - Pet portclippy.

    The patch is based on the patch form Zoltán Király
    <ports@zoltankiraly.com>.

    PR:             285208
    MFH:            2025Q1
    (cherry picked from commit 907e7f6b1eacacbc7d427c5ff62f2143033376ad)

 audio/lollypop/Makefile  | 19 +++++++++----------
 audio/lollypop/distinfo  | 10 +++++-----
 audio/lollypop/pkg-plist |  3 +++
 3 files changed, 17 insertions(+), 15 deletions(-)
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-07 10:12:04 UTC
Thanks!