Bug 285225 - devel/ioncube: Update to 14.4.0
Summary: devel/ioncube: Update to 14.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-07 13:15 UTC by Christos Chatzaras
Modified: 2025-03-16 10:15 UTC (History)
2 users (show)

See Also:
svyatoslav.lempert: maintainer-feedback+


Attachments
git diff for ioncube 14.4.0 update (1.43 KB, patch)
2025-03-07 13:15 UTC, Christos Chatzaras
no flags Details | Diff
Update ioncube to version 14.4.0 (3.24 KB, patch)
2025-03-07 14:01 UTC, Christos Chatzaras
bofh: maintainer-approval-
Details | Diff
ioncube-14.4.0 (2.99 KB, patch)
2025-03-16 03:27 UTC, Svyatoslav Lempert
svyatoslav.lempert: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christos Chatzaras 2025-03-07 13:15:27 UTC
Created attachment 258395 [details]
git diff for ioncube 14.4.0 update

This version is compatible with PHP 8.3 and 8.4.
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2025-03-07 13:39:15 UTC
As you are already submitting git diff patches it's easier for us if you submit the entire commit. Like for this it will be something like this:

```
devel/ioncube: Update version 13.0.2=>14.4.0

PR: 285225
Approved by: svyatoslav.lempert@gmail.com (maintainer)
Changelog: <ADD CHANGELOG URL>
```

Then do something like:
```
git format-patch -1 HEAD -U9999 --output-directory=<YOUR_HOME_DIRECTORY>
```

A common mistake is people think that they need to attach a patch when they are creating the PR. No. You can create and attach the patch after creating the PR.
Comment 2 Christos Chatzaras 2025-03-07 14:01:14 UTC
Created attachment 258398 [details]
Update ioncube to version 14.4.0
Comment 3 Christos Chatzaras 2025-03-07 14:04:11 UTC
(In reply to Muhammad Moinur Rahman from comment #1)

Thank you for your help! Could you please check if the new patch is correct?

I’m not the port maintainer. Should we wait for Svyatoslav’s approval?
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2025-03-07 14:07:55 UTC
The patch looks good.

And yes we have to wait for approval or 14 days whichever is shorter.
Comment 5 Svyatoslav Lempert 2025-03-16 03:27:26 UTC
Created attachment 258712 [details]
ioncube-14.4.0

Please commit this, added i386 arch
Comment 6 Svyatoslav Lempert 2025-03-16 03:29:16 UTC
Comment on attachment 258398 [details]
Update ioncube to version 14.4.0

missed i386
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-03-16 10:15:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86eb46db16af396db5209d4975c6f3a5c03fe974

commit 86eb46db16af396db5209d4975c6f3a5c03fe974
Author:     Svyatoslav Lempert <svyatoslav.lempert@gmail.com>
AuthorDate: 2025-03-16 10:09:42 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2025-03-16 10:14:12 +0000

    devel/ioncube: Update version 13.0.2=>14.4.0

    - Adds support for php 8.3 and 8.4

    PR:             285225
    Reported by:    chris@cretaforce.gr

 devel/ioncube/Makefile |  3 +--
 devel/ioncube/distinfo | 12 ++++++------
 2 files changed, 7 insertions(+), 8 deletions(-)