Bug 285289 - x11/budgie-desktop: Fix build with Vala 0.56.18
Summary: x11/budgie-desktop: Fix build with Vala 0.56.18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://portsfallout.com/port/34043/
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-09 16:15 UTC by Olivier Duchateau
Modified: 2025-03-24 04:44 UTC (History)
2 users (show)

See Also:
duchateau.olivier: maintainer-feedback+


Attachments
Fix build with Vala 0.56.18 (1.55 KB, patch)
2025-03-09 16:15 UTC, Olivier Duchateau
duchateau.olivier: maintainer-approval+
Details | Diff
fix-budgie-2.patch (2.85 KB, patch)
2025-03-22 04:15 UTC, Jesús Daniel Colmenares Oviedo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2025-03-09 16:15:55 UTC
Created attachment 258490 [details]
Fix build with Vala 0.56.18

- Add upstream patch in order to fix build with Vala 0.56.18 (commit 8feb8c7)
- Bump PORTREVISION
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2025-03-17 09:43:10 UTC
The build still fails for me with this patch applied:

../src/panel/applets/icon-tasklist/animation.vala:31.2-31.37: error: Compact class `BudgieTaskList.Animation' cannot inherit from non-compact class `GLib.Object'
   31 |         public class Animation : GLib.Object {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 2 Jesús Daniel Colmenares Oviedo 2025-03-22 04:15:30 UTC
Created attachment 258900 [details]
fix-budgie-2.patch

Based on the patch, there is another file to fix that is now included with this new patch. I have tested this on a jail, so I needed to install x11-wm/mutter for budgie to work, does budgie work for you guys without x11-wm/mutter?
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2025-03-22 17:16:04 UTC
Olivier, can you please check this new patch and approve it if it is OK?
Comment 4 Olivier Duchateau 2025-03-23 15:07:40 UTC
(In reply to Gleb Popov from comment #3)

It looks good to me
Comment 5 Olivier Duchateau 2025-03-23 15:11:14 UTC
(In reply to Jesús Daniel Colmenares Oviedo from comment #2)

Budgie desktop is based on magpie (a fork of mutter). According to upstream both libraries can be installed in parallel.
Comment 6 Jesús Daniel Colmenares Oviedo 2025-03-23 18:11:42 UTC
(In reply to Olivier Duchateau from comment #5)

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-03-24 04:43:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ce897ff1bfc4fb39b211fab12c5c996327c2468

commit 9ce897ff1bfc4fb39b211fab12c5c996327c2468
Author:     Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org>
AuthorDate: 2025-03-24 04:41:54 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2025-03-24 04:42:32 +0000

    x11/budgie-desktop: Unbreak build after Vala upgrade

    PR:             285289
    Approved by:    Olivier Duchateau <duchateau.olivier@gmail.com> (maintainer)

 x11/budgie-desktop/Makefile                                    |  2 +-
 x11/budgie-desktop/files/patch-src_lib_animation.vala (new)    | 10 ++++++++++
 .../patch-src_panel_applets_icon-tasklist_animation.vala (new) | 10 ++++++++++
 x11/budgie-desktop/files/patch-src_panel_manager.vala (new)    | 10 ++++++++++
 .../files/patch-src_panel_settings_themes.vala (new)           | 10 ++++++++++
 5 files changed, 41 insertions(+), 1 deletion(-)
Comment 8 Gleb Popov freebsd_committer freebsd_triage 2025-03-24 04:44:17 UTC
Pushed, thanks everyone.