Bug 285341 - net/openmpi: Fix 16 byte atomic operations on amd64
Summary: net/openmpi: Fix 16 byte atomic operations on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-11 23:30 UTC by Laurent Chardon
Modified: 2025-03-12 11:04 UTC (History)
1 user (show)

See Also:
laurent.chardon: maintainer-feedback+
vvd: merge-quarterly+


Attachments
net/openmpi 4.0.7-1 patch (732 bytes, patch)
2025-03-11 23:30 UTC, Laurent Chardon
laurent.chardon: maintainer-approval+
Details | Diff
net/openmpi 5.0.7-1 patch (732 bytes, patch)
2025-03-11 23:31 UTC, Laurent Chardon
no flags Details | Diff
net/openmpi patch for 2025Q1 (1.20 KB, patch)
2025-03-12 09:26 UTC, Laurent Chardon
laurent.chardon: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Chardon 2025-03-11 23:30:36 UTC
Created attachment 258583 [details]
net/openmpi 4.0.7-1 patch

Fix an issue with 16 byte atomic operations on amd64.
See https://github.com/open-mpi/ompi/issues/13134

QA: OK
Comment 1 Laurent Chardon 2025-03-11 23:31:59 UTC
Created attachment 258584 [details]
net/openmpi 5.0.7-1 patch
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-12 00:11:51 UTC
"merge-quarterly"?
Comment 3 Laurent Chardon 2025-03-12 00:32:32 UTC
Good idea. The new version should be backward compatible, and will be in Q2 in a couple of weeks anyways.

Thanks for the suggestion.
Comment 4 Laurent Chardon 2025-03-12 01:18:53 UTC
Upon reflection, it's better not to merge it into quarterly because there are many untested dependencies. It's better to wait for Q2.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-03-12 01:21:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07722f6ed2aa26e76ae830cfc26341788f4b7195

commit 07722f6ed2aa26e76ae830cfc26341788f4b7195
Author:     Laurent Chardon <laurent.chardon@gmail.com>
AuthorDate: 2025-03-12 01:16:12 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-12 01:16:12 +0000

    net/openmpi: Fix 16 byte atomic operations on amd64

    Clang does not support 16 byte atomic operations without -mcx16 on amd64
    Upstream issue: https://github.com/open-mpi/ompi/issues/13134

    PR:     285341
    MFH:    2025Q1

 net/openmpi/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-12 01:23:11 UTC
(In reply to Laurent Chardon from comment #4)
Maybe merge only part with "CFLAGS+=-mcx16"?

P.S. While here pet portclippy.
Comment 7 Laurent Chardon 2025-03-12 09:26:29 UTC
Created attachment 258597 [details]
net/openmpi patch for 2025Q1

This patch is for the merge-quarterly into Q1 (version 5.0.6).

Same change as for 5.0.7, plus a line moved for portclippy.
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-03-12 10:45:08 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=da3c0949ffea763452de09bd8c7b5026851489dc

commit da3c0949ffea763452de09bd8c7b5026851489dc
Author:     Laurent Chardon <laurent.chardon@gmail.com>
AuthorDate: 2025-03-12 01:16:12 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-03-12 10:43:36 +0000

    net/openmpi: Fix 16 byte atomic operations on amd64

    Clang does not support 16 byte atomic operations without -mcx16 on amd64
    Upstream issue: https://github.com/open-mpi/ompi/issues/13134

    PR:     285341
    MFH:    2025Q1
    (cherry picked from commit 07722f6ed2aa26e76ae830cfc26341788f4b7195)

 net/openmpi/Makefile | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-12 10:57:23 UTC
Thanks.
Comment 10 Laurent Chardon 2025-03-12 11:04:05 UTC
Thank you!