Bug 285387 - lang/gnat12: missing ali files for aarch64
Summary: lang/gnat12: missing ali files for aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-13 23:01 UTC by Jonathan Chen
Modified: 2025-04-23 02:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (thierry)


Attachments
gnat12 git diff (2.32 KB, patch)
2025-03-13 23:01 UTC, Jonathan Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2025-03-13 23:01:32 UTC
Created attachment 258646 [details]
gnat12 git diff

The latest re-org to lang/gnat12 has resulted in excluding some required ali files from the port; in particular, those reported in Bug 279996.

This has resulted in build failures for devel/gprbuild on aarch64.

I'm a bit wary of breaking the build for i386, so the attached patch introduces a new PLIST_SUB for amd64 and aarch64. This works on my local builds for these architectures, but I do not have an i386 system to test against.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2025-03-15 10:34:16 UTC
Committed (with a minor fix for i386), thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-03-15 10:35:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ff83d52a78069dfe99ce5930923ffb37e39383b6

commit ff83d52a78069dfe99ce5930923ffb37e39383b6
Author:     Jonathan Chen <jonc@chen.org.nz>
AuthorDate: 2025-03-15 10:32:24 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2025-03-15 10:32:24 +0000

    lang/gnat12: add missing ali files for aarch64

    PR:             285387
    Reported by:    jonc (at) chen.org.nz

 lang/gnat12/Makefile  |  9 ++++++---
 lang/gnat12/pkg-plist | 12 ++++++------
 2 files changed, 12 insertions(+), 9 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-04-23 02:05:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d5f5193e2db974576120b5e5f559970a6c15247d

commit d5f5193e2db974576120b5e5f559970a6c15247d
Author:     Adrian Chadd <adrian@FreeBSD.org>
AuthorDate: 2025-04-01 23:57:41 +0000
Commit:     Adrian Chadd <adrian@FreeBSD.org>
CommitDate: 2025-04-23 02:02:47 +0000

    rtwn: don't treat UDP/TCP checksum failure as permanent failure

    jrtc27@freebsd.org reported that DHCP wasn't working on some
    networks.  She dug into it and found that the RTL8812AU/RTL8812AU
    NICs seem to be failing UDP frames w/ a zero checksum, which is
    a valid "there's no checksum" checksum.

    So, just pass those frames up the stack and let the IP stack
    deal with it.  If the hardware claims the frames did pass TCP/UDP
    checksum then still mark those frames with the checksum offload
    bits.

    PR:     kern/285387
    Differential Revision:  https://reviews.freebsd.org/D49628

 sys/dev/rtwn/rtl8812a/r12a_rx.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)