Bug 285519 - x11/xterm: requires gtk-pixbuf-extra now
Summary: x11/xterm: requires gtk-pixbuf-extra now
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-19 05:31 UTC by Stephen Hurd
Modified: 2025-03-21 08:38 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Hurd freebsd_committer freebsd_triage 2025-03-19 05:31:51 UTC
The icons are xpm, see the 20250316 UPDATING entry
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-03-20 09:11:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a737df258430d63fc9a0977364b264b66b63ae01

commit a737df258430d63fc9a0977364b264b66b63ae01
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2025-03-20 09:11:12 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2025-03-20 09:11:24 +0000

    x11/xterm: Now requires gtk-pixbuf-extra

    Add gdkpixbufextra:run dependency as GNOME, previously optional adding
    desktop-file-utils use flag, is now mandatory.

    PR:             285519
    Notified by:    shurd

 x11/xterm/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2025-03-20 09:13:54 UTC
Fixed, thanks.
Comment 3 Gunther Nikl 2025-03-20 17:51:17 UTC
(In reply to commit-hook from comment #1)
> x11/xterm: Now requires gtk-pixbuf-extra
Sorry, but this cannot be correct! I have deactivated the GNOME setting and xterm runs fine. Checking the source shows that Xpm support comes from libXpm, see misc.c.

The commit should be reverted.
Comment 4 Stephen Hurd freebsd_committer freebsd_triage 2025-03-20 18:40:47 UTC
Unfortunately, it's not about XTerm running, it's about the icon in the XTerm desktop file displaying in GNOME-based desktop environments.

The Icon specified in xterm.desktop is an XPM file, which means anything "displaying" the desktop entry needs XPM support, which per the 20250316 UPDATING entry means USE_GNOME=gdkpixbufextra:run

This is pretty ugly, which is why I added vishwin to the CC list when I filed it.
Comment 5 Charlie Li freebsd_committer freebsd_triage 2025-03-20 18:47:06 UTC
Yeah I don't think adding USE_GNOME=gdkpixbufextra:run just for an icon is good here. Better to declare in desktop environment ports, probably those that deal with displaying icons specified in .desktop files.
Comment 6 Stephen Hurd freebsd_committer freebsd_triage 2025-03-20 21:03:09 UTC
(In reply to Charlie Li from comment #5)

I sounds like that means it should be added to all ports that already use gtk-pixbuf and may be asked to display anything that's not part of that port... which sounds a lot like it should be a default dependency of gtk-pixbuf itself.
Comment 7 Stephen Hurd freebsd_committer freebsd_triage 2025-03-20 21:42:43 UTC
Anyway, regarding the XTerm port, I've been convinced this should be reverted.
Comment 8 Emanuel Haupt freebsd_committer freebsd_triage 2025-03-21 08:27:29 UTC
I agree that this issue should be addressed on the WM level. I'll revert the change. Thank you all for your input.
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-03-21 08:38:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31f5dae36b3c01ee0f9337984dc186770770c643

commit 31f5dae36b3c01ee0f9337984dc186770770c643
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2025-03-21 08:34:37 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2025-03-21 08:34:37 +0000

    x11/xterm: Revert previous commit

    Further discussion concluded that the gdkpixbufextra dependency should be
    handled elsewhere (e.g., by the Window Manager).

    PR:             285519

 x11/xterm/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)