Bug 285737 - net-im/signal-desktop 7.48 fails to build
Summary: net-im/signal-desktop 7.48 fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-29 07:45 UTC by FiLiS
Modified: 2025-04-02 09:45 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description FiLiS freebsd_committer freebsd_triage 2025-03-29 07:45:02 UTC 
just got that when trying to build the latest version:

--
...
gyp sill build/config.gypi node_install_corepack: 'true',
gyp sill build/config.gypi node_install_npm: 'true',
gyp sill build/config.gypi node_library_files: [
gyp sill build/config.gypi 'lib/_http_agent.js',
gyp sill build/config.gypi 'lib/_http_client.js',
gyp sill build/config.gypi 'lib/_http_common.js',
gyp sill build/config.gypi 'lib/_http_incoming.js',
gyp sill build/config.gypi 'lib/_htt
  ⨯ node-gyp failed to rebuild '/wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-7.48.0/node_modules/canvas'  failedTask=installAppDeps stackTrace=Error: node-gyp failed to rebuild '/wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-7.48.0/node_modules/canvas'
    at ChildProcess.<anonymous> (/wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-7.48.0/node_modules/.pnpm/@electron+rebuild@3.7.0/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:121:24)
    at ChildProcess.emit (node:events:524:28)
    at ChildProcess._handle.onexit (node:internal/child_process:293:12)
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/signal-desktop
=>> Cleaning up wrkdir
===>  Cleaning for signal-desktop-7.48.0
build of net-im/signal-desktop | signal-desktop-7.48.0 ended at Sat Mar 29 08:11:01 CET 2025
build time: 00:19:56
!!! build failure encountered !!!

-- 
am I missing anything?
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2025-03-29 10:11:58 UTC 
I can also reproduce this on 14.2-RELEASE (amd64) in Poudriere
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-03-30 19:16:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb67926b17258b6a7b9faaaddf220e165613c387

commit fb67926b17258b6a7b9faaaddf220e165613c387
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2025-03-30 18:36:27 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2025-03-30 19:15:44 +0000

    net-im/signal-desktop: fix build

      Add missing pkgconfig, it's needed to build node_modules/canvas
      Bump electron version (again)

    While here:
      Cleanup useless ${RM}

    PR:             285737

 net-im/signal-desktop/Makefile | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
Comment 3 FiLiS freebsd_committer freebsd_triage 2025-04-02 09:45:14 UTC 
looking good over here