Bug 285815 - net/xrdp fails on run-depends stage
Summary: net/xrdp fails on run-depends stage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks: 285325
  Show dependency treegraph
 
Reported: 2025-03-31 18:25 UTC by Anton Saietskii
Modified: 2025-04-02 08:04 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (meta)


Attachments
poudriere build log (219.98 KB, text/plain)
2025-03-31 18:25 UTC, Anton Saietskii
no flags Details
xorgxrdp poudriere build log (10.90 KB, application/x-compressed)
2025-04-01 13:17 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2025-03-31 18:25:33 UTC
Created attachment 259224 [details]
poudriere build log

[releng142-default-job-01] |   `-- Extracting xkeyboard-config-2.41_4: .......... done
[releng142-default-job-01] `-- Extracting xorg-server-21.1.16,1: .......... done
pkg-static: Missing shlib dependency: libglamoregl.so

Failed to install the following 1 package(s): /packages/All/xorgxrdp-0.10.4.pkg
=====
Comment 1 Anton Saietskii 2025-04-01 13:17:58 UTC
Created attachment 259240 [details]
xorgxrdp poudriere build log

Sorry for attaching previous log uncompressed.

I suppose issue may be related to recent pkg's shlib tracking changes. However, it's unclear for me why it can't find glamor lib as driver is built with it.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2025-04-01 16:09:12 UTC
Yeah, I think it's related to pkg 2.1.0.
https://cgit.freebsd.org/ports/commit/?id=ba7d9cfe04fb85fbd86013c4c1d01ffce95dc9b0
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2025-04-01 16:41:05 UTC
Unfortunately, I think I can do nothing on x11-drivers/xorgxrdp side. I suppose it is totally pkg issue.
Comment 4 Anton Saietskii 2025-04-01 17:21:48 UTC
(In reply to Koichiro Iwao from comment #3)

I've seen some private shlib-related (?) variable in Makefile's, but I don't remeber its name... Though perhaps it's the one we may use?
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2025-04-01 17:31:06 UTC
It might be an issue of x11-servers/xorg-server rather than pkg. x11-drivers/xorgxrdp depends on libglamoregl.so however it is not listed on shlibs that xorg-server provides. Therefore, pkg cannot find libglamoregl.so when installing xorgxrdp. 

$ pkg info -l xorgxrdp
xorgxrdp-0.10.4:
        libc.so.7
        libepoxy.so.0
        libglamoregl.so

$ pkg info -b xorg-server
xorg-server-21.1.16,1:
(nothing)

However, libglamoregl.so is certainly included in xorg-server package. 

$ pkg info -l xorg-server | grep \.so$
        /usr/local/lib/xorg/modules/drivers/modesetting_drv.so
        /usr/local/lib/xorg/modules/extensions/libglx.so
        /usr/local/lib/xorg/modules/input/inputtest_drv.so
        /usr/local/lib/xorg/modules/libexa.so
        /usr/local/lib/xorg/modules/libfbdevhw.so
        /usr/local/lib/xorg/modules/libglamoregl.so
        /usr/local/lib/xorg/modules/libint10.so
        /usr/local/lib/xorg/modules/libshadow.so
        /usr/local/lib/xorg/modules/libshadowfb.so
        /usr/local/lib/xorg/modules/libvgahw.so
        /usr/local/lib/xorg/modules/libwfb.so
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2025-04-01 17:36:25 UTC
(In reply to Anton Saietskii from comment #4)
pkg searches shlibs based on each package's manifest. So I think Makefile variable doesn't help in this case. 

The correct solution I guess is to register such shlibs in the manifest of xorg-server.  Then pkg can find libglamoregl.so and doesn't complain.
Comment 7 Baptiste Daroussin freebsd_committer freebsd_triage 2025-04-02 06:31:22 UTC
the issue here, is xorgrdp is linked with to l libglamoregl.so which is not provided by xorg-server (as in not available in regular ldconfig path) so xorg-server packages is not listing it in the available provided libs and pkg claims a provide/requires it not satisfied here.

I bet it works fine anyway for xorgxrp because xorgrdp have runpath applied to its binaries so the manages to resolves, in that case the best is simply to tell pkg to ignore the requirement on libglarmorgl.so:

NO_SHLIB_REQUIRES_GLOB=libglarmordl.so

in xrdp makefile should do the trick.
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-04-02 07:30:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=687b2f44b3eff4d8d7579c78b48845a2ae69c99b

commit 687b2f44b3eff4d8d7579c78b48845a2ae69c99b
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2025-04-02 07:17:06 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2025-04-02 07:29:51 +0000

    x11-drivers/xorgxrdp: Fix build with pkg 2.1.0

    Fix suggested by bapt.

    While here, reformat Makefile with portfmt, and pet portclippy.

    PR:             285815
    Reported by:    Anton Saietskii
    Sponsored by:   Cybertrust Japan

 x11-drivers/xorgxrdp/Makefile | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-04-02 07:30:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cfb71f4ea6c6825b49f28e7f0401a5bc2e0fe0a0

commit cfb71f4ea6c6825b49f28e7f0401a5bc2e0fe0a0
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2025-04-02 07:26:00 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2025-04-02 07:29:51 +0000

    x11-drivers/xorgxrdp-devel: Fix build with pkg 2.1.0

    Fix suggested by bapt.

    While here, reformat Makefile with portfmt, and pet portclippy.

    PR:             285815
    Reported by:    Anton Saietskii
    Sponsored by:   Cybertrust Japan

 x11-drivers/xorgxrdp-devel/Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2025-04-02 07:33:39 UTC
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07c29a572cb9b942b01b97298d41064665255909

commit 07c29a572cb9b942b01b97298d41064665255909
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2025-04-02 07:17:06 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2025-04-02 07:31:43 +0000

    x11-drivers/xorgxrdp: Fix build with pkg 2.1.0

    Fix suggested by bapt.

    While here, reformat Makefile with portfmt, and pet portclippy.

    PR:             285815
    Reported by:    Anton Saietskii
    Sponsored by:   Cybertrust Japan

    (cherry picked from commit 687b2f44b3eff4d8d7579c78b48845a2ae69c99b)

 x11-drivers/xorgxrdp/Makefile | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2025-04-02 07:33:40 UTC
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9787f71de921f5960126f721a66a1f8c21741077

commit 9787f71de921f5960126f721a66a1f8c21741077
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2025-04-02 07:26:00 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2025-04-02 07:31:51 +0000

    x11-drivers/xorgxrdp-devel: Fix build with pkg 2.1.0

    Fix suggested by bapt.

    While here, reformat Makefile with portfmt, and pet portclippy.

    PR:             285815
    Reported by:    Anton Saietskii
    Sponsored by:   Cybertrust Japan

    (cherry picked from commit cfb71f4ea6c6825b49f28e7f0401a5bc2e0fe0a0)

 x11-drivers/xorgxrdp-devel/Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Comment 12 Koichiro Iwao freebsd_committer freebsd_triage 2025-04-02 08:04:28 UTC
Committed, thank you both!