Bug 285888 - emulators/es-de: update to 3.2.0
Summary: emulators/es-de: update to 3.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://gitlab.com/es-de/emulationsta...
Keywords:
Depends on:
Blocks: 286062
  Show dependency treegraph
 
Reported: 2025-04-04 19:59 UTC by Stefan Schlosser
Modified: 2025-04-21 18:32 UTC (History)
1 user (show)

See Also:


Attachments
update to 3.2.0 (23.33 KB, patch)
2025-04-04 19:59 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
v2 (23.33 KB, patch)
2025-04-20 13:37 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schlosser 2025-04-04 19:59:21 UTC
Created attachment 259325 [details]
update to 3.2.0

Release notes:
https://gitlab.com/es-de/emulationstation-de/-/releases/v3.2.0

* unbundle graphics/lunasvg


The patch contains additional cosmetic/auxillary changes:
- _BR_DEPENDS is now placed above BUILD_DEPENDS where it's used.
- Paths in BUILD_DEPENDS are replaced with the "port notation" (e.g. cimg>0:graphics/cimg). This looks alot cleaner.
- graphics/lunasvg was the last bundled dependency in the external directory. We can now exclude this directory from extraction via EXTRACT_AFTER_ARGS and simplify its handling in the CMakeLists.txt patch.
- Addition of find_package(RapidJSON REQUIRED) in the CMakeLists.txt patch when unbundling devel/rapidjson was actually never needed. So it got removed.
Comment 1 Stefan Schlosser 2025-04-20 13:37:50 UTC
Created attachment 259737 [details]
v2

Rebase patch after PORTREVISION bump by https://cgit.freebsd.org/ports/commit/?id=78c4bd4996cb3ff6e7aa6285205745d705d2188e
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2025-04-21 18:31:56 UTC
Thanks for your work, Stefan! Committed!
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-04-21 18:32:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7c3b6b4d955803e0a575822c9cf475db66fca30d

commit 7c3b6b4d955803e0a575822c9cf475db66fca30d
Author:     Stefan Schlosser <bsdcode@disroot.org>
AuthorDate: 2025-04-21 18:28:01 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2025-04-21 18:31:43 +0000

    emulators/es-de: Update to 3.2.0

    Unbundle graphics/lunasvg: was the last bundled dependency in the external
    directory. We can now exclude this directory from extraction via
    EXTRACT_AFTER_ARGS and simplify its handling in the CMakeLists.txt
    patch.
    Paths in BUILD_DEPENDS are replaced with the "port notation".
    Addition of find_package(RapidJSON REQUIRED) in the CMakeLists.txt patch
    when unbundling devel/rapidjson was actually never needed. So it got
    removed.

    Changelog:
    https://gitlab.com/es-de/emulationstation-de/-/releases/v3.2.0

    PR:             285888
    Approved by:    submitter is maintainer

 emulators/es-de/Makefile                           | 26 +++++-----
 emulators/es-de/distinfo                           |  6 +--
 emulators/es-de/files/patch-CMakeLists.txt         | 58 +++++++++++++---------
 .../files/patch-external_CMakeLists.txt (gone)     | 23 ---------
 emulators/es-de/pkg-plist                          | 47 +++++++++++++++++-
 5 files changed, 96 insertions(+), 64 deletions(-)