Bug 285954 - sysutils/deskflow: Update to 1.21.2
Summary: sysutils/deskflow: Update to 1.21.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://github.com/deskflow/deskflow/...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-08 06:36 UTC by Yoshiaki Kasahara
Modified: 2025-05-06 04:25 UTC (History)
2 users (show)

See Also:
ykasap: maintainer-feedback+


Attachments
Update to 1.21.2 (3.24 KB, patch)
2025-04-08 06:36 UTC, Yoshiaki Kasahara
ykasap: maintainer-approval+
Details | Diff
Update to 1.21.2 (updated) (3.62 KB, patch)
2025-05-02 19:11 UTC, Yoshiaki Kasahara
ykasap: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Kasahara 2025-04-08 06:36:10 UTC
Created attachment 259385 [details]
Update to 1.21.2

Update sysutils/deskflow to 1.21.2.

ChangeLog:
https://github.com/deskflow/deskflow/releases/tag/v1.21.2

Manpages are generated by help2man, so I added build dependency and updated the pkg-plist.  Also, I made a patch to amend manpages containing working and staging directory paths.

I checked with poudriere and portlint on a 14.2-RELEASE (amd64) jail.
Comment 1 Siva Mahadevan freebsd_triage 2025-04-23 00:31:06 UTC
^Triage: add changelog to URL, set status to Open.
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2025-05-02 06:24:20 UTC
Comment on attachment 259385 [details]
Update to 1.21.2

Your patch can't apply:
+        COMMAND sed -i.bak -e \'s|$<TARGET_FILE_DIR:${target}>/||\'
error: patch failed: sysutils/deskflow/Makefile:1
error: sysutils/deskflow/Makefile: patch does not apply
error: patch failed: sysutils/deskflow/distinfo:1
error: sysutils/deskflow/distinfo: patch does not apply
Comment 3 Yoshiaki Kasahara 2025-05-02 19:11:48 UTC
Created attachment 260095 [details]
Update to 1.21.2 (updated)

The port was updated by kde@ on Apr 27, but I was not notified about that.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286051
The fix had already been included in 1.21.2.
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2025-05-03 09:17:28 UTC
(In reply to Yoshiaki Kasahara from comment #3)
Thanks.

But this port doesn't build on 13.4:
-- tomlplusplus [System] Version: 3.4.0
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR: Found unsuitable version "1.1.1w", but
  required is at least "3.0" (found /usr/lib/libcrypto.so, found components:
  SSL Crypto)
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:601 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake/Modules/FindOpenSSL.cmake:691 (find_package_handle_standard_args)
  src/lib/net/CMakeLists.txt:13 (find_package)


-- Configuring incomplete, errors occurred!


Could you please check?
Comment 5 Yoshiaki Kasahara 2025-05-05 14:11:26 UTC
Do you set TRYBROKEN?
This port is BROKEN on FreeBSD 13 because the base OpenSSL is too old.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284703#c6
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2025-05-06 03:18:20 UTC
(In reply to Yoshiaki Kasahara from comment #5)
Sorry, you're right. I didn't check Makefile again and poudriere doesn't show any warning about it.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2025-05-06 04:24:15 UTC
Thanks for your work, Yoshiaki! Committed.
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-05-06 04:25:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37f601b185c607e756a985743d69ee50f8968a6a

commit 37f601b185c607e756a985743d69ee50f8968a6a
Author:     Yoshiaki Kasahara <ykasap@gmail.com>
AuthorDate: 2025-05-06 04:22:09 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2025-05-06 04:23:49 +0000

    sysutils/deskflow: Update to 1.21.2

    Add help2man to build dependenceies and generate manual files.

    Changelog: https://github.com/deskflow/deskflow/releases/tag/v1.21.2

    PR:             285954
    Approved by:    submitted is maintainer

 sysutils/deskflow/Makefile                                  |  6 +++---
 sysutils/deskflow/distinfo                                  |  8 +++-----
 sysutils/deskflow/files/patch-src_apps_CMakeLists.txt (new) | 12 ++++++++++++
 sysutils/deskflow/pkg-plist                                 |  3 +++
 4 files changed, 21 insertions(+), 8 deletions(-)