Bug 286127 - net/remmina: switch to libsoup3
Summary: net/remmina: switch to libsoup3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-16 00:12 UTC by Vladimir Druzenko
Modified: 2025-04-16 15:54 UTC (History)
1 user (show)

See Also:
fernape: maintainer-feedback+

Attachments
v1 (1.32 KB, patch)
2025-04-16 00:12 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2025-04-16 00:12:22 UTC 
Created attachment 259598 [details]
v1

By default remmina grab webkit2gtk-4.1 if installed both webkit2gtk-4.0 and webkit2gtk-4.1.
Same for libsoup: 3.0 vs 2.4.
Also it prefer libayatana-appindicator3.so instead of libappindicator3.so.

Tested build in poudriere and live system on 14.2 amd64.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-04-16 00:18:58 UTC 
No cmake parameter WITH_APPINDICATOR. Current name is HAVE_LIBAPPINDICATOR.
But this option prevent search and use libayatana-appindicator3.so and libappindicator3.so.
We can create option APPINDICATOR if you want.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-04-16 13:49:52 UTC 
> Flags: maintainer-feedback?(fernape@FreeBSD.org) → maintainer-feedback+
Is this a patch approval and can I commit it?
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2025-04-16 13:56:56 UTC 
(In reply to Vladimir Druzenko from comment #2)
Yes.
It is a PR approval and there is only one patch in the PR :-)

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-04-16 15:51:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d80e7fffbf13fa5c0f698924aadceee28ab0c57

commit 7d80e7fffbf13fa5c0f698924aadceee28ab0c57
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-04-16 13:35:01 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-04-16 15:49:01 +0000

    net/remmina: Switch to upstream preferred library selection: webkit2gtk-4.1, libsoup3, libayatana-appindicator

    By default remmina grab webkit2gtk-4.1 if installed both webkit2gtk-4.0
    and webkit2gtk-4.1. Same for libsoup: 3.0 vs 2.4.
    Also remmina prefer devel/libayatana-appindicator instead of
    devel/libappindicator as APPINDICATOR.

    PR:             286127
    Approved by:    fernape (maintainer)

 net/remmina/Makefile | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-04-16 15:54:37 UTC 
Thanks!