Bug 286410 - graphics/drm-kmod: bad logic in commit 324e88dfe4263b1a091432692ec21294967174d8
Summary: graphics/drm-kmod: bad logic in commit 324e88dfe4263b1a091432692ec21294967174d8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-28 07:26 UTC by Trond Endrestøl
Modified: 2025-04-28 07:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Proposed patch for graphics/drm-kmod/Makefile (819 bytes, patch)
2025-04-28 07:26 UTC, Trond Endrestøl 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2025-04-28 07:26:09 UTC 
Created attachment 259942 [details]
Proposed patch for graphics/drm-kmod/Makefile

I fail to see how the logic in commit 324e88dfe4263b1a091432692ec21294967174d8 will provide the desired outcome for all cases.
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-04-28 07:34:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1e0de31a575b5506814ee6850878912e0eee5049

commit 1e0de31a575b5506814ee6850878912e0eee5049
Author:     Trond Endrestøl <Trond.Endrestol@ximalas.info>
AuthorDate: 2025-04-28 07:32:51 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2025-04-28 07:33:31 +0000

    graphics/drm-kmod: Fix logic

    PR:     286410

 graphics/drm-kmod/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2025-04-28 07:35:08 UTC 
Thanks, looks like I needed more coffee.