Bug 286917 - biology/lamarc: unbreak on FreeBSD 14+
Summary: biology/lamarc: unbreak on FreeBSD 14+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason W. Bacon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-19 00:22 UTC by Hayzam Sherif
Modified: 2025-05-20 11:33 UTC (History)
1 user (show)

See Also:


Attachments
Git patch to unbreak biology/lamarc on FreeBSD 14+ (6.95 KB, patch)
2025-05-19 00:22 UTC, Hayzam Sherif
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayzam Sherif 2025-05-19 00:22:06 UTC
Created attachment 260525 [details]
Git patch to unbreak biology/lamarc on FreeBSD 14+

Lamarc fails to build on FreeBSD 14+ with Clang 16+ due to use of
std::make_pair with explicit template arguments and lvalues, which
is no longer valid in C++17 and later.

This patch removes the explicit template arguments in several locations
and lets the compiler deduce them correctly, restoring build success.

Also:
- Regenerated patch-src_tools_stringx.h to reflect correct context and line offsets

Tested on: FreeBSD 14.2-RELEASE-p2 amd64
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-05-20 11:33:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba0d68b692fcc71071225a45fcb317373fec01fa

commit ba0d68b692fcc71071225a45fcb317373fec01fa
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2025-05-20 11:27:40 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2025-05-20 11:27:40 +0000

    biology/lamarc: Unbreak build on 14.x

    Remove dynamic casts forcing unsupported types
    2.1.10 was released, but the download site is broken
    Contacted upstream but not response yet

    PR:             286917
    Reported by:    hayzam@alchemilla.io

 biology/lamarc/Makefile                                 |  6 +++---
 .../files/patch-src_control_chainmanager.cpp (new)      | 11 +++++++++++
 biology/lamarc/files/patch-src_tools_mathx.cpp (new)    | 11 +++++++++++
 biology/lamarc/files/patch-src_tools_stringx.h          | 10 +++++-----
 .../lamarc/files/patch-src_tree_arrangervec.cpp (new)   | 11 +++++++++++
 biology/lamarc/files/patch-src_tree_collector.cpp (new) | 11 +++++++++++
 biology/lamarc/files/patch-src_tree_prior.cpp (new)     | 17 +++++++++++++++++
 7 files changed, 69 insertions(+), 8 deletions(-)
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2025-05-20 11:33:38 UTC
Thanks!