Bug 287172 - filesystems/openzfs compatibility flags are behind %%TESTS%% prefix
Summary: filesystems/openzfs compatibility flags are behind %%TESTS%% prefix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-30 22:33 UTC by q5sys
Modified: 2025-05-31 18:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mm)


Attachments
compatibility files patch to remove %%TESTS%% prefix (5.59 KB, patch)
2025-05-30 22:33 UTC, q5sys
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description q5sys 2025-05-30 22:33:37 UTC
Created attachment 260819 [details]
compatibility files patch to remove %%TESTS%% prefix

All of the zfs compatibility files are currently using the %%TESTS%% prefix in pkg-plist, They are not available unless someone also builds the entire test suite. These compatibility files should be available on all openzfs installs and not bound exclusively with the test suite.
Comment 1 Herbert J. Skuhra 2025-05-31 06:32:49 UTC
Btw. 

%%TESTS%%share/zfs/compatibility.d/openzfsonosx-1.7.0

or

share/zfs/compatibility.d/openzfsonosx-1.7.0

is listed twice.

Error: Missing: share/zfs/compatibility.d/openzfsonosx-1.7.0
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-05-31 17:41:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f0f7a6ededa8f35830439981c26dfebf9f761f3e

commit f0f7a6ededa8f35830439981c26dfebf9f761f3e
Author:     Martin Matuska <mm@FreeBSD.org>
AuthorDate: 2025-05-31 17:40:37 +0000
Commit:     Martin Matuska <mm@FreeBSD.org>
CommitDate: 2025-05-31 17:40:37 +0000

    filesystems/openzfs: pkg-plist fixes

    Always install share/zfs/compatibility.d files
    Remove duplicate file in pkg-plist

    PR:     287172

 filesystems/openzfs/Makefile  |   1 +
 filesystems/openzfs/pkg-plist | 105 +++++++++++++++++++++---------------------
 2 files changed, 53 insertions(+), 53 deletions(-)
Comment 3 q5sys 2025-05-31 18:16:48 UTC
(In reply to Herbert J. Skuhra from comment #1)
Thanks for getting that cleaned up for me. I was in the middle of 5 things, all of them annoying when I made that patch, looks likes I fat fingered that one. But thanks for fixing it for me!